Avoid race condition(s) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arichard4 Any chance you could take a gander at my fix here? It works but I'm not 100% sure why in multi-threading mode the |
alerque
force-pushed
the
threadsafe
branch
2 times, most recently
from
6d8563f
to
f0bcdd3
Compare
Trying to stash the state outside of the function and access it from any other scope creates problems for multi-threaded runs. Passing it around in the function calls keeps it local to the current scope even when/if more than one may be running.
|
Makes sense, thanks! |
|
Thanks for the review. And sorry I should have commented as well, but my first "work around" posted here when I first pinged you was a pretty dirty hack. I later figured out a way to accomplish the same thing without it feeling dirty and things made much more sense, which is why I went ahead with the merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
Closes #54