Fix warning 582 (error prone negation) not applying to subexpressions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
force-pushed
the
fix-582-subexps
branch
from
16a1c64
to
9accd16
Compare
appgurueu
force-pushed
the
fix-582-subexps
branch
from
9accd16
to
14fbbc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warning 582 not applying properly to subexpressions; the checks were applied to
node[1]rather than directly tonode. Furthermore it also checks forx == not ynow; I've also added some tests for some variants of the error prone negation.See minetest/minetest_game#3032 (comment) for the motivation behind this.