Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve luasec integration issues #102

Closed
wants to merge 6 commits into from
Closed

Conversation

r-nikhil
Copy link

No description provided.

run test.lua after installing the new https.lua to test redirects. https-1.lua is the old https.lua. the present one has http functions from luasocket
@r-nikhil
Copy link
Author

Like suggested here by @Tieske in the comment, I included the entire http.lua file from luasocket with some changes.

@daurnimator
Copy link
Contributor

'http2' is really terrible naming here: it suggests HTTP2 protocol support.

@@ -1,3 +1,4 @@
/src/*.o
/src/luasocket/*.o
/*.dll
/samples/certs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline at end of file

@r-nikhil
Copy link
Author

@daurnimator HTTP2 support would be added once the integration issues(redirects, proxy etc) are solved. I would be working on this the entire summer. You can see the actual roadmap here

@daurnimator
Copy link
Contributor

daurnimator commented May 26, 2017

@daurnimator HTTP2 support would be added once the integration issues(redirects, proxy etc) are solved. I would be working on this the entire summer. You can see the actual roadmap here

Oh.. huh... I already wrote a lua http library with http 2 support here: https://github.com/daurnimator/lua-http/. and it includes all the features you're adding....

I disagree that those features should be in luasec in any case: IMO luasec should just provide SSL primitives and leave various protocols for other libraries.

@r-nikhil
Copy link
Author

A pull request shall be opened once the work is complete

@r-nikhil r-nikhil closed this May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants