Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPAddress encoding #21

Merged
merged 4 commits into from
Jan 28, 2015
Merged

iPAddress encoding #21

merged 4 commits into from
Jan 28, 2015

Conversation

Zash
Copy link
Contributor

@Zash Zash commented Jun 8, 2014

Calling x509cert:extensions() on a certificate containing iPAddress SANs will return those IP addresses as raw bytes.

Additionally, if combined with x509cert:setencode("utf8"), the ASN1_STRING_to_UTF8() call will fail and nothing will be pushed.

The first first 3 commits fixes issues by returning nil instead of something invalid. The last commit uses inet_ntop() to convert IP addresses to the common string form.

brunoos added a commit that referenced this pull request Jan 28, 2015
@brunoos brunoos merged commit a9b81b1 into lunarmodules:master Jan 28, 2015
@Tieske Tieske mentioned this pull request Mar 8, 2015
@Zash Zash deleted the zash/iPAddress-fix branch December 8, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants