Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API reference + checkhostname + symbol visibility fix #49

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

API reference + checkhostname + symbol visibility fix #49

wants to merge 17 commits into from

Conversation

bartbes
Copy link

@bartbes bartbes commented Jun 26, 2015

I realise it's a bit weird to send a pull request for 3 things at once, and if needed I can split them up and send 3 requests instead. Anyway, here goes:

  • I've created a small api reference, as that is something I couldn't find
  • I've add a checkhostname function that checks whether the peer's certificate is valid for the given hostname, and made https.request check it. Note that without such a check, anyone with a valid certificate for anything could easily pull of a man-in-the-middle attack.
  • I've changed the symbol visibility on linux so only the luasec api is exported

If there's any subset you want separated, give me a shout.

bartbes added 17 commits June 4, 2015 13:00
@bartbes
Add gitignore file
7663d9e
@bartbes
Add indentation settings to .vimrc file for people with exrc set
7ca7890
@bartbes
Create list of functions and methods to be documented
54db93c
@bartbes
Document functions of 'ssl' module
d84a0a9
@bartbes
Ignore html files too
3122867
@bartbes
Add simple inotify-based script to update doc html files
9d6e35b
@bartbes
Document connection object
9420dcd
@bartbes
Document core module
4f714ed
@bartbes
Document certs
4658af3
@bartbes
Document the context module
88fa9b8
@bartbes
Add ssl.checkhostname and conn:checkhostname
cde1517 
Convenient (and important!) methods that allow checking for hostnames
against a (peer) certificate. Deals with wildcards and alternative names
(via the dnsnames extension).
@bartbes
Make https request fail if hostname does not match
6a828b3
@bartbes
Unexport meth_extensions
2fc8a85
@bartbes
Add connection helper ssl.connect
7de198b
@bartbes
Add https module documentation
b229059
@bartbes
Clean up external symbols by changing visibility on linux/gcc
8e0e1d2
@bartbes
Fix call to global 'ssl' where it is not available
2052842
@bartbes
Copy link
Author

bartbes commented Jun 13, 2016

Is there any progress on this? It's been almost a year at this point.

@johannesboon johannesboon mentioned this pull request May 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bartbes