ls_sqlite3: conditional use of lua_isinteger #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `lua_isinteger` function is only present in Lua 5.3. To maintain compatibility with earlier Lua versions (notably 5.2 and 5.1) this commit gates the usage of this function with `defined` pre-processor checks. In the case where the symbol is not defined, we unconditionally fall back to existing logic that treats the maybe-an-int item in question as if `lua_isinteger` returned false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lua_isintegerfunction is only present in Lua 5.3+. To maintain compatibility with earlier Lua versions (notably 5.2 and 5.1) this pull request gates the usage of this function withdefinedpre-processor checks. In the case where the symbol is not defined, we unconditionally fall back to existing logic that treats the maybe-an-int item in question as iflua_isintegerreturned false.Resolves #147