Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline Payment referencing old cart->order relation #1139

Closed
glennjacobs opened this issue Jul 10, 2023 · 0 comments
Closed

Offline Payment referencing old cart->order relation #1139

glennjacobs opened this issue Jul 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@glennjacobs
Copy link
Contributor

glennjacobs commented Jul 10, 2023 •
edited

See https://github.com/lunarphp/lunar/blob/0b54f4d269e15b60b4b4bd12ba9dfef86eb5d112/packages/core/src/PaymentTypes/OfflinePayment.php#L18C54-L18C54

Most likely needs changing to draftOrder().

Also need to ensure we have test coverage for this, as it should have been picked up.
@glennjacobs glennjacobs added the bug Something isn't working label Jul 10, 2023
@glennjacobs glennjacobs mentioned this issue Jul 10, 2023
Merged
2 tasks
@jclee100 jclee100 mentioned this issue Jul 10, 2023
Closed
glennjacobs added a commit that referenced this issue Aug 18, 2023
@glennjacobs
Hotfix to Offline payment driver referencing old order relation (#1140)
c78aec9 
This update aims to fix the offline payment driver which was referencing
the old cart->order relation, which no longer exists. See #1139
alecritson pushed a commit that referenced this issue Aug 18, 2023
@glennjacobs @alecritson
Hotfix to Offline payment driver referencing old order relation (#1140)
3efe74a 
This update aims to fix the offline payment driver which was referencing
the old cart->order relation, which no longer exists. See #1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glennjacobs