Add tax reference field to hub #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neondigital/getcandy-2-docs/GYBsRsgF4EbYqjo9HqNp2797Cxkf |
glennjacobs
approved these changes
Feb 1, 2022
alecritson
added a commit
that referenced
this pull request
Feb 1, 2022
* add translations to variants * Add default scope to url * Add default url relationship * Apply fixes from StyleCI * Make sure the variant image is set to primary * Check for variant thumbnail first * Feature - Pricing manager (#95) * Start pricing manager * Tweaks and tests * Logic and test updates * Tweak tier unit tests * Reorder methods * Add currency test * Add facade * Add user tests * Change calculate line to use manager * Apply fixes from StyleCI * Fix syntax * Remove get price methods * Move away from singleton * Throw exception if currency price not found * Reset manager once finished * Fix tests * Apply fixes from StyleCI * Flesh out the interface * Update docs for pricing * Update return type docblock Co-authored-by: StyleCI Bot <bot@styleci.io> * Add country to factory * Update changelogs * Allow /hub to be changed through a config setting (#88) * Allow /hub to be changed through a config setting * Change url to path * Remove duplicate init since upgrade (#103) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * Update README.md (#101) Typo corrected * Update CHANGELOG.md * Feature: Fix tests when running from core (#108) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * Fix tests when running from core Co-authored-by: Alec Ritson <hello@itsalec.co.uk> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> * Update CHANGELOG.md * fix[Core/Tests]: Fix duplicated array key (#105) * patch[Core]: Update return type on productType method (#104) * Bug: dashboard placed_at throws error when null (#92) * placed_at -> created_at * Revert "placed_at -> created_at" This reverts commit 838c225. * Make placed_at optional * Update CHANGELOG.md * Update CHANGELOG.md * fix option validation of other language (#94) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * fix option validation of other language update hard code 'en' to defaultLanguage property Co-authored-by: Alec Ritson <hello@itsalec.co.uk> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> * Apply fixes from StyleCI * Apply fixes from StyleCI * Enhancement - Tweaks to CartManager and how addresses are handled (#116) * Update address instead of re create * Handle creating new address from object * Tweaks and tests * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Hotfix - Shipping option pricing (#117) * Fix pricing * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Bug: Don't assume user has a customer associated yet (#89) * Dont assume user has a customer associated yet * Update * StyleCI * StyleCI * Use trait * StyleCI * Update changelog * Update changelogs * Update upgrade guide * Update CHANGELOG.md * Prevent pricing saving twice (#121) * Add additional check * Apply fixes from StyleCI * Create ProductCreateTest.php * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Update CHANGELOG.md * Prevent duplicate cart lines (#122) * Default to empty array * Ensure all lines are loaded * Update CartManagerTest.php * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Add tax reference field to hub (#123) * Add tax reference field * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Description should not be required (#124) * Description should not be required * Make descriptions non system attributes * Update changelogs * Update upgrading.md * Update release headings Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Ryan Mitchell <ryan@thoughtcollective.com> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> Co-authored-by: Richard <richardw@redmule.co.uk> Co-authored-by: Joel Male <joel@joelmale.com> Co-authored-by: green-mike <m65432102000@hotmail.com>
alecritson
added a commit
that referenced
this pull request
Feb 1, 2022
* add translations to variants * Add default scope to url * Add default url relationship * Apply fixes from StyleCI * Make sure the variant image is set to primary * Check for variant thumbnail first * Feature - Pricing manager (#95) * Start pricing manager * Tweaks and tests * Logic and test updates * Tweak tier unit tests * Reorder methods * Add currency test * Add facade * Add user tests * Change calculate line to use manager * Apply fixes from StyleCI * Fix syntax * Remove get price methods * Move away from singleton * Throw exception if currency price not found * Reset manager once finished * Fix tests * Apply fixes from StyleCI * Flesh out the interface * Update docs for pricing * Update return type docblock Co-authored-by: StyleCI Bot <bot@styleci.io> * Add country to factory * Update changelogs * Allow /hub to be changed through a config setting (#88) * Allow /hub to be changed through a config setting * Change url to path * Remove duplicate init since upgrade (#103) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * Update README.md (#101) Typo corrected * Update CHANGELOG.md * Feature: Fix tests when running from core (#108) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * Fix tests when running from core Co-authored-by: Alec Ritson <hello@itsalec.co.uk> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> * Update CHANGELOG.md * fix[Core/Tests]: Fix duplicated array key (#105) * patch[Core]: Update return type on productType method (#104) * Bug: dashboard placed_at throws error when null (#92) * placed_at -> created_at * Revert "placed_at -> created_at" This reverts commit 838c225. * Make placed_at optional * Update CHANGELOG.md * Update CHANGELOG.md * fix option validation of other language (#94) * Fix reference to generate variants * patch[Docs]: Remove duplicated editLinks prop (#87) * Docs update: Fixed shipping/billing address (#93) * fixed shipping/billing address * fixed billing address * fix option validation of other language update hard code 'en' to defaultLanguage property Co-authored-by: Alec Ritson <hello@itsalec.co.uk> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> * Apply fixes from StyleCI * Apply fixes from StyleCI * Enhancement - Tweaks to CartManager and how addresses are handled (#116) * Update address instead of re create * Handle creating new address from object * Tweaks and tests * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Hotfix - Shipping option pricing (#117) * Fix pricing * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Bug: Don't assume user has a customer associated yet (#89) * Dont assume user has a customer associated yet * Update * StyleCI * StyleCI * Use trait * StyleCI * Update changelog * Update changelogs * Update upgrade guide * Update CHANGELOG.md * Prevent pricing saving twice (#121) * Add additional check * Apply fixes from StyleCI * Create ProductCreateTest.php * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Update CHANGELOG.md * Prevent duplicate cart lines (#122) * Default to empty array * Ensure all lines are loaded * Update CartManagerTest.php * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Add tax reference field to hub (#123) * Add tax reference field * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io> * Description should not be required (#124) * Description should not be required * Make descriptions non system attributes * Update changelogs * Update upgrading.md * Update release headings Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Ryan Mitchell <ryan@thoughtcollective.com> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> Co-authored-by: Richard <richardw@redmule.co.uk> Co-authored-by: Joel Male <joel@joelmale.com> Co-authored-by: green-mike <m65432102000@hotmail.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Ryan Mitchell <ryan@thoughtcollective.com> Co-authored-by: Everett (Mike) Wiley <servnx@gmail.com> Co-authored-by: NaincyKumariKnoldus <87004609+NaincyKumariKnoldus@users.noreply.github.com> Co-authored-by: Richard <richardw@redmule.co.uk> Co-authored-by: Joel Male <joel@joelmale.com> Co-authored-by: green-mike <m65432102000@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to add the missing
tax_refvariant field to the hub so it's editable by users.