Moving Asset registration of lunar-panel css to Panel definition #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glennjacobs
approved these changes
Jul 5, 2024
|
Thanks @abishekrsrikaanth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the registration of the lunar-panel.css is being within
Filament:servingmethod which is triggered only on a Filament Panel request. So, this causes an issue of the assets registered within it not being published whenphp artisan filament:upgradeis being called. Sincelunar-panel.cssneeds to only be served for the Lunar panel requests, it is ideal that the asset registration can be moved where the Lunar Panel is being setup.