Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default payment type #863

Merged
merged 3 commits into from
Feb 21, 2023
Merged

change default payment type #863

merged 3 commits into from
Feb 21, 2023

Conversation

wychoong
Copy link
Contributor

  • currently default payment type config is set to env('PAYMENTS_TYPE', 'offline'), which is wrong as offline payment type is not provided, the provided is offline driver
  • added payment-offline status for order
  • order status component to show label as 'N/A' when status label is null

@vercel
Copy link

vercel bot commented Feb 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 11:21AM (UTC)

@wychoong wychoong mentioned this pull request Feb 16, 2023
Merged
@alecritson alecritson enabled auto-merge (squash) February 21, 2023 13:33
@alecritson alecritson merged commit 0b9b9fc into lunarphp:0.2 Feb 21, 2023
@wychoong wychoong deleted the fix/default-payment-type branch February 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennjacobs glennjacobs glennjacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wychoong @glennjacobs @alecritson