refactor(lsp): cleanup servers' override configuration #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abzcoding
reviewed
Feb 3, 2022
kylo252
force-pushed
the
refactor-lsp-override
branch
from
8e1f9d0
to
bb47ea2
Compare
|
This renaming is a great initiative. When I just started using lunarvim (not that long ago), the whole "overwrites" was confusing because in fact, it was not overwriting anything, it was disabling. I also like the idea of putting this inside "automatic_configuration". In general in natural language it should sound like "ignored servers by the automatic configuration". My only concern in the change, and this is of course something that needs to be changed in the website documentation, is how you document it. A new user to the editor could easily think that because you are "ignoring" a server, it means it will never be used or installed when in fact is merely ignored for automatic configuration. |
- rename lsp.override to lsp.automatic_configuration.ignored_servers - add lsp.automatic_configuration.ignored_filetypes
kylo252
force-pushed
the
refactor-lsp-override
branch
from
bb47ea2
to
5ed708a
Compare
kylo252
force-pushed
the
refactor-lsp-override
branch
from
5ed708a
to
01dacf4
Compare
just fix this and we are good to go 👍 |
|
also, can you fix the windows example config? |
kylo252
force-pushed
the
refactor-lsp-override
branch
from
01dacf4
to
0f7e2af
Compare
I must've messed something up in one of the rebases, since I need to add all those servers manually again 🥲 also, wdyt about the variable names? |
kylo252
force-pushed
the
refactor-lsp-override
branch
from
6c83308
to
7712a63
Compare
variable name looks fine to me 👍 |
Closed
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Apr 27, 2022
* upstream/rolling: (48 commits) refactor: lock new installations to nvim v0.7+ (LunarVim#2526) fix(readme): remove black as linter (LunarVim#2510) fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509) feat(installer): ensure correct responses when prompting user (LunarVim#2506) feat(peek): make sure max width and height are customizable (LunarVim#2492) chore: bump plugins version (LunarVim#2459) fix(nvimtree): escape the dot character in custom filter (LunarVim#2493) refactor: update impatient (LunarVim#2477) feat: lock nvim <0.7 to a specific tag (LunarVim#2491) fix(luasnip): only use user snippets if the folder exists (LunarVim#2481) fix(lualine): color theme gaps in some components (LunarVim#2465) fix(cmp): bring back default keybindings (LunarVim#2470) fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) fix(readme): update lsp server ignore syntax refactor(lsp): cleanup servers' override configuration (LunarVim#2243) feat(cmp): documentation is deprecated in favor of window.documentation (LunarVim#2461) docs(windows): use alpha in config_win.example.lua (LunarVim#2452) chore: bump plugins version (LunarVim#2448) fix(impatient): avoid get_options in fast handler (LunarVim#2451) fix(luasnip): make sure all snippets are loaded (LunarVim#2447) ...
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Apr 27, 2022
* upstream/master: (63 commits) chore: update changelog refactor: lock new installations to nvim v0.7+ (LunarVim#2526) fix(readme): remove black as linter (LunarVim#2510) fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509) feat(installer): ensure correct responses when prompting user (LunarVim#2506) feat(peek): make sure max width and height are customizable (LunarVim#2492) chore: bump plugins version (LunarVim#2459) fix(nvimtree): escape the dot character in custom filter (LunarVim#2493) chore: update changelog refactor: update impatient (LunarVim#2477) feat: lock nvim <0.7 to a specific tag (LunarVim#2491) fix(luasnip): only use user snippets if the folder exists (LunarVim#2481) fix(lualine): color theme gaps in some components (LunarVim#2465) fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) (LunarVim#2469) fix(cmp): bring back default keybindings (LunarVim#2470) fix(cmp): hotfix nvim-cmp version fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) chore: update changelog fix(readme): update lsp server ignore syntax refactor(lsp): cleanup servers' override configuration (LunarVim#2243) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lvim.lsp.overridetolvim.lsp.automatic_configuration.ignored_serverslvim.lsp.automatic_configuration.skipped_serverslvim.lsp.automatic_configuration.ignored_filetypeslvim.lsp.automatic_configuration.skipped_filetypesFixes issue with keeping up with new markdown servers that keeps getting added..
TODOs
config.example.lua