Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock nvim <0.7 to a specific tag #2491

Merged
merged 1 commit into from Apr 20, 2022
Merged

feat: lock nvim <0.7 to a specific tag #2491

merged 1 commit into from Apr 20, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Apr 20, 2022

Description

  • require v0.7+ for starting lunarvim (prevent issues with manual update)
  • running :LvimUpdate when using a neovim <0.7 should switch to the tag 1.1.3 automatically and print a warning message

Related #2476

How Has This Been Tested?

@kylo252 kylo252 added enhancement New feature or request packaging labels Apr 20, 2022
@kylo252 kylo252 requested a review from abzcoding April 20, 2022 09:24
@kylo252 kylo252 added this to In Progress in LunarVim via automation Apr 20, 2022
Copy link
Member

@abzcoding abzcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kylo252 kylo252 merged commit 3d84142 into rolling Apr 20, 2022
LunarVim automation moved this from In Progress to Done Apr 20, 2022
@kylo252 kylo252 deleted the version-lock branch April 20, 2022 09:44
@derekwilling
Copy link

derekwilling commented Apr 27, 2022

FYI, all the docs still show Lunarvim requires >= v0.6.1 Neovim, and on fresh installs of Lunarvim I am getting an error saying v0.7+ is required with v0.6.1 installed

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Apr 27, 2022
* upstream/rolling: (48 commits)
  refactor: lock new installations to nvim v0.7+ (LunarVim#2526)
  fix(readme): remove black as linter (LunarVim#2510)
  fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509)
  feat(installer): ensure correct responses when prompting user (LunarVim#2506)
  feat(peek): make sure max width and height are customizable (LunarVim#2492)
  chore: bump plugins version (LunarVim#2459)
  fix(nvimtree): escape the dot character in custom filter (LunarVim#2493)
  refactor: update impatient (LunarVim#2477)
  feat: lock nvim <0.7 to a specific tag (LunarVim#2491)
  fix(luasnip): only use user snippets if the folder exists (LunarVim#2481)
  fix(lualine): color theme gaps in some components (LunarVim#2465)
  fix(cmp): bring back default keybindings (LunarVim#2470)
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467)
  fix(readme): update lsp server ignore syntax
  refactor(lsp): cleanup servers' override configuration (LunarVim#2243)
  feat(cmp): documentation is deprecated in favor of window.documentation (LunarVim#2461)
  docs(windows): use alpha in config_win.example.lua (LunarVim#2452)
  chore: bump plugins version (LunarVim#2448)
  fix(impatient): avoid get_options in fast handler (LunarVim#2451)
  fix(luasnip): make sure all snippets are loaded (LunarVim#2447)
  ...
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Apr 27, 2022
* upstream/master: (63 commits)
  chore: update changelog
  refactor: lock new installations to nvim v0.7+ (LunarVim#2526)
  fix(readme): remove black as linter (LunarVim#2510)
  fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509)
  feat(installer): ensure correct responses when prompting user (LunarVim#2506)
  feat(peek): make sure max width and height are customizable (LunarVim#2492)
  chore: bump plugins version (LunarVim#2459)
  fix(nvimtree): escape the dot character in custom filter (LunarVim#2493)
  chore: update changelog
  refactor: update impatient (LunarVim#2477)
  feat: lock nvim <0.7 to a specific tag (LunarVim#2491)
  fix(luasnip): only use user snippets if the folder exists (LunarVim#2481)
  fix(lualine): color theme gaps in some components (LunarVim#2465)
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) (LunarVim#2469)
  fix(cmp): bring back default keybindings (LunarVim#2470)
  fix(cmp): hotfix nvim-cmp version
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467)
  chore: update changelog
  fix(readme): update lsp server ignore syntax
  refactor(lsp): cleanup servers' override configuration (LunarVim#2243)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants