fix(nvimtree): escape the dot character in custom filter #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! some minor fixes are needed to pass the CI tests
git commit --amend --no-edit --message "fix(nvimtree): escape the dot character in custom filter"
git push --force -uCheck the contributing guidelines in https://github.com/LunarVim/LunarVim/blob/rolling/CONTRIBUTING.md. |
hansemschnokeloch
changed the title
hansemschnokeloch
force-pushed
the
patch-1
branch
from
ccb734f
to
124ff40
Compare
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Apr 27, 2022
* upstream/rolling: (48 commits) refactor: lock new installations to nvim v0.7+ (LunarVim#2526) fix(readme): remove black as linter (LunarVim#2510) fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509) feat(installer): ensure correct responses when prompting user (LunarVim#2506) feat(peek): make sure max width and height are customizable (LunarVim#2492) chore: bump plugins version (LunarVim#2459) fix(nvimtree): escape the dot character in custom filter (LunarVim#2493) refactor: update impatient (LunarVim#2477) feat: lock nvim <0.7 to a specific tag (LunarVim#2491) fix(luasnip): only use user snippets if the folder exists (LunarVim#2481) fix(lualine): color theme gaps in some components (LunarVim#2465) fix(cmp): bring back default keybindings (LunarVim#2470) fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) fix(readme): update lsp server ignore syntax refactor(lsp): cleanup servers' override configuration (LunarVim#2243) feat(cmp): documentation is deprecated in favor of window.documentation (LunarVim#2461) docs(windows): use alpha in config_win.example.lua (LunarVim#2452) chore: bump plugins version (LunarVim#2448) fix(impatient): avoid get_options in fast handler (LunarVim#2451) fix(luasnip): make sure all snippets are loaded (LunarVim#2447) ...
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Apr 27, 2022
* upstream/master: (63 commits) chore: update changelog refactor: lock new installations to nvim v0.7+ (LunarVim#2526) fix(readme): remove black as linter (LunarVim#2510) fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509) feat(installer): ensure correct responses when prompting user (LunarVim#2506) feat(peek): make sure max width and height are customizable (LunarVim#2492) chore: bump plugins version (LunarVim#2459) fix(nvimtree): escape the dot character in custom filter (LunarVim#2493) chore: update changelog refactor: update impatient (LunarVim#2477) feat: lock nvim <0.7 to a specific tag (LunarVim#2491) fix(luasnip): only use user snippets if the folder exists (LunarVim#2481) fix(lualine): color theme gaps in some components (LunarVim#2465) fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) (LunarVim#2469) fix(cmp): bring back default keybindings (LunarVim#2470) fix(cmp): hotfix nvim-cmp version fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) chore: update changelog fix(readme): update lsp server ignore syntax refactor(lsp): cleanup servers' override configuration (LunarVim#2243) ...
PasiBergman
pushed a commit
to PasiBergman/LunarVim
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nvimtree custom filter is a list of vim regex https://github.com/kyazdani42/nvim-tree.lua/blob/0f0f858348aacc94f98ba32880760c5a5440b825/doc/nvim-tree-lua.txt#L453-L457
Escaping the dot character avoids to filter filenames like "acache", "icache" etc