feat: add cmp-tmux to the list of sources #2542
Conversation
kylo252
changed the title
* upstream/rolling: feat: add cmp-tmux to the list of sources (LunarVim#2542) feat: gitsigns yadm support (LunarVim#2535) fix(installer): latest and specified release version for neovim have different urls (LunarVim#2484) fix(lsp): undo stdpath overload to avoid datarace (LunarVim#2540) feat(lua-dev): use the newer lua-dev branch till folke comes back (LunarVim#2538) fix(nvimtree): add latest changes from nvimtree (LunarVim#2537) feat(icons): make it possible to disable icons (LunarVim#2529) refactor(lsp): decouple the installer setup-hook (LunarVim#2536)
|
What is the intention behind this? As far as I know ,that cmp extension is not shipped by default |
it makes it so that you don't have to manually add tmux to the list of recognizable sources, so just installing the plugin would make it work fine with cmp, tabnine is another example. |
|
While that is understandable, I think it serves no purpose. First because
it is not documented , so unless tu take the time to read the entire
lunarvim code base, you are the original implementers of this,or you are
being told about it in discord, you will have no idea. Second, because if
you follow the extension instructions ,you will end with this config
duplicated, which I think it is undefined behavior .
And last, if I get it correctly, there is no way to configure from users
space? Please let me know if I'm wrong.
So, probably the best solution is to document it
El sáb., 11 jun. 2022 12:04, kylo252 ***@***.***> escribió:
… What is the intention behind this? As far as I know ,that cmp extension is
not shipped by default
it makes it so that you don't have to manually add tmux to the list of
recognizable sources, so just installing the plugin would make it work fine
with cmp, tabnine is another example.
—
Reply to this email directly, view it on GitHub
<#2542 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWM7VBS477UDCXH4VPTVORQDNANCNFSM5UW43RZA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Another solution would be to simply ship https://github.com/andersevenrud/cmp-tmux with the default plugins of lunarvim. This plugin is lightweight and tmux is very common imho. |
I think that would open the flood doors to including all of cmp's sources 🤔 |
|
Thats true. Maybe a separate configuration file for cmp that has all sources listed at https://github.com/hrsh7th/nvim-cmp/wiki/List-of-sources but COMMENTED by default could be shipped with lunarvim. One just needs to uncomment the cmp plugins he is interested in ? |
@thyseus, please create a PR to update this list with some of the missing useful/common sources LunarVim/utils/installer/config.example.lua Lines 96 to 102 in 9f1f983 and maybe another PR to add them to the site 😄 |
Description
This adds tmux to the cmp sources.
https://github.com/andersevenrud/cmp-tmux
How Has This Been Tested?
Tested locally, cmp-tmux works as expected.