Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add option to override nlsp-settings #2769

Merged
merged 2 commits into from Jun 27, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Jun 27, 2022

Description

add a new lvim.lsp.nlsp_settings.setup table for configuring https://github.com/tamago324/nlsp-settings.nvim

  • fix(lsp): update nlsp's json schemas path
  • feat(lsp): add option to override nlsp-settings

How Has This Been Tested?

integration with schemastore.nvim will now actually work :)

@kylo252 kylo252 requested a review from abzcoding June 27, 2022 15:25
Copy link
Member

@abzcoding abzcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kylo252 kylo252 changed the title fix-jsonls) feat(lsp): add option to override nlsp-settings feat(lsp): add option to override nlsp-settings Jun 27, 2022
@kylo252 kylo252 merged commit a99894b into LunarVim:rolling Jun 27, 2022
@kylo252 kylo252 deleted the fix-jsonls branch June 27, 2022 17:18
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Jul 1, 2022
* upstream/rolling:
  fix dap-install (LunarVim#2772)
  feat(lsp): add option to override nlsp-settings (LunarVim#2769)
  feat(lsp): add option to override default `nvim-lsp-installer` settings (LunarVim#2698)
  fix(installer): always use check shallow clones (LunarVim#2763)
  ci: update runners to include nightly neovim (LunarVim#2756)
  fix(installer): use full path to verify_plugins.lua (LunarVim#2755)
  feat(installer): add verify-plugins hook (LunarVim#2751)
  fix(lualine): unique buf client names (LunarVim#2683)
  chore(lsp): notify format request failed once when there is no client (LunarVim#2697)
  feat: fix a couple of issues (LunarVim#2750)
  chore: bump plugins version (LunarVim#2699)
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Aug 21, 2022
* upstream/master: (21 commits)
  chore: update changelog
  fix(installer) comment causes antivirus false positives (LunarVim#2818)
  fix(nvimtree): remove `indent_markers` icons trailing space (LunarVim#2854)
  fix: use pcall for setting up project.nvim (LunarVim#2762)
  fix(lvim/lsp/manager): make client_is_configured more reliable (LunarVim#2851)
  perf(cmp): remove redundant check for emmet-ls (LunarVim#2830)
  chore: update changelog
  feat(lsp): bind formatexpr and omnifunc by default (LunarVim#2865)
  chore: bump plugins version (LunarVim#2723)
  fix(packer): add max_jobs = 40 (LunarVim#2781)
  Update general-issue-form.yaml
  refactor(whichkey): use vim.keymap.set directly (LunarVim#2786)
  fix(core.comment): fix default extra mappings (LunarVim#2768)
  fix: typo in utils/installer/install.sh (LunarVim#2776)
  fix(lsp): update format filter for nightly (LunarVim#2773)
  feat: add commands to open/edit lvim logs (LunarVim#2709)
  fix dap-install (LunarVim#2772)
  feat(lsp): add option to override nlsp-settings (LunarVim#2769)
  feat(lsp): add option to override default `nvim-lsp-installer` settings (LunarVim#2698)
  fix(installer): always use check shallow clones (LunarVim#2763)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants