Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): handle INSTALL_PREFIX not on PATH #2912

Merged
merged 2 commits into from Aug 19, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Aug 13, 2022

Description

  • feat(installer): handle INSTALL_PREFIX not on PATH
  • feat: skip optional deps on permission errors

fixes #2905

How Has This Been Tested?

add this rule to Makefile

install-local:
	@echo starting LunarVim local test installer
	@env \
		INSTALL_PREFIX=/tmp/p2 \
		NPM_HOME=/usr/local \
		LUNARVIM_CONFIG_DIR=/tmp/p2/xdg/config \
		LUNARVIM_RUNTIME_DIR=/tmp/p2/xdg/data \
		LUNARVIM_BASE_DIR=/tmp/p2/xdg/data/lvim \
		bash ./utils/installer/install.sh --local

@kylo252 kylo252 requested a review from rebuilt August 13, 2022 09:41
@kylo252 kylo252 merged commit 08b5e99 into LunarVim:rolling Aug 19, 2022
@kylo252 kylo252 deleted the installer-prefix-validate branch August 19, 2022 10:02
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Aug 21, 2022
* upstream/rolling: (30 commits)
  chore: bump plugins version (LunarVim#2895)
  feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912)
  docs: fix automatic_servers_installation example (LunarVim#2918)
  docs: fix some typos and enhance readability (LunarVim#2917)
  fix(statusline): display null-ls linters properly (LunarVim#2921)
  docs(windows): update example config (LunarVim#2919)
  refactor(keymaps)!: don't hijack H/L by default (LunarVim#2874)
  chore: bump plugins version (LunarVim#2893)
  fix(lsp): return the actual resolved mason-config (LunarVim#2889)
  docs(windows): update example config for nvim-tree (LunarVim#2766)
  fix(installer): create profile.ps1 if nonexistent (LunarVim#2810)
  fix(lualine): set icon color according to the status of treesitter (LunarVim#2754)
  feat(lvim/lsp): enable tailwindcss by default (LunarVim#2870)
  fix: handle deprecated telescope.builtin.internal (LunarVim#2885)
  refactor!: migrate to mason.nvim (LunarVim#2880)
  feat(whichkey): add default keybindings to cycle to next buffer (LunarVim#2873)
  fix(installer) comment causes antivirus false positives (LunarVim#2818)
  fix(nvimtree): remove `indent_markers` icons trailing space (LunarVim#2854)
  fix: use pcall for setting up project.nvim (LunarVim#2762)
  fix(lvim/lsp/manager): make client_is_configured more reliable (LunarVim#2851)
  ...
@danielo515
Copy link
Contributor

Worked like a charm, thans

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Sep 14, 2022
* upstream/master: (30 commits)
  fix(plugins): handle deprecated options (LunarVim#3014)
  fix(core/autocmds): do not check for existence on clear_augroup (LunarVim#2963)
  fix(cmp): fix cmp select on CR (LunarVim#2980)
  fix(plugins): bring back original folke repos (LunarVim#2992)
  chore: bump plugins version (LunarVim#2972)
  fix(cmp): do not mutate the original confirm_opts on CR (LunarVim#2979)
  docs(lsp): fix the way of removing items from skipped_servers (LunarVim#2887)
  chore: remove unnecessary code (LunarVim#2923)
  chore: update changelog
  chore: bump plugins version (LunarVim#2925)
  fix(ts_context_commentstring): block comment match new api (LunarVim#2948)
  fix(lsp): pass name arg to should_auto_install (LunarVim#2958)
  refactor(cmp)!: adapt new recommendations (LunarVim#2913)
  fix: update key bindings for comment.nvim to use new api (LunarVim#2926)
  chore: bump plugins version (LunarVim#2895)
  feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912)
  docs: fix automatic_servers_installation example (LunarVim#2918)
  docs: fix some typos and enhance readability (LunarVim#2917)
  fix(statusline): display null-ls linters properly (LunarVim#2921)
  docs(windows): update example config (LunarVim#2919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script fails to find "lvim" command
2 participants