Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics #21

Merged
merged 29 commits into from
Aug 25, 2020
Merged

Add metrics #21

merged 29 commits into from
Aug 25, 2020

Conversation

JacobValdemar
Copy link
Member

@JacobValdemar JacobValdemar commented Aug 24, 2020 •
edited
Loading

Many changes:

  • Migrate from baseapp to net/http http server
  • Create middlewares for logging and metrics
  • Add metrics middleware for inbound and outbound http traffic
  • Add metrics middleware for Github webhooks
  • Expose /metrics endpoint to prometheus

@JacobValdemar JacobValdemar marked this pull request as ready for review August 24, 2020 10:26
Crevil
Crevil requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes here and there, but overall this is nicely done 🥇

httpMiddleware.go Outdated Show resolved Hide resolved
httpMiddleware.go Outdated Show resolved Hide resolved
httpMiddleware.go Outdated Show resolved Hide resolved
httpMiddleware.go Outdated Show resolved Hide resolved
httpMiddleware.go Outdated Show resolved Hide resolved
httpMiddleware.go Outdated Show resolved Hide resolved
issue_release_status.go Outdated Show resolved Hide resolved
issue_release_status.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
JacobValdemar and others added 14 commits August 24, 2020 13:01
Crevil
Crevil approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎸

@JacobValdemar JacobValdemar merged commit 6e9e261 into master Aug 25, 2020
@JacobValdemar JacobValdemar deleted the feature/metrics branch August 25, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crevil Crevil Crevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JacobValdemar @Crevil