Add context to http server log middleware #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the HTTP logging middleware adds the requst ID to its context fields
twice and further ignores any other context values in the logger.
info http/server.go:2122 [200] GET /status {"requestId": "73efeeb4-af33-46b5-b31b-6dbd21efa245", "req": {"id":"73efeeb4-af33-46b5-b31b-6dbd21efa245","url":"/status?service=test-service","method":"GET","path":"/status","headers":{"Accept-Encoding":"gzip","Authorization":"Bearer test","User-Agent":"Go-http-client/1.1","X-Cli-Version":"7fce8c29f7bbc1e38d683713aca5fa42c43215a8","X-Request-Id":"73efeeb4-af33-46b5-b31b-6dbd21efa245"}}, "res": {"statusCode":200}, "responseTime": 3}
This change removes the excessive request ID fields and uses a context logger,
which automatically has the request ID available. This simplifies the middleware
a bit but also allows for other context values to be propagated in the logging
context, eg. subject when OAuth2.0 support is added.
info http/server.go:2122 [404] GET /policies {"requestId": "b8ac36e3-f72c-4146-b43b-d61b02fb92f0", "req": {"url":"/policies?service=test","method":"GET","path":"/policies","headers":{"Accept-Encoding":"gzip","Authorization":"Bearer test","User-Agent":"Go-http-client/1.1","X-Caller-Email":"bso@lunar.app","X-Cli-Version":"96e2ef7d006e6b0e44aca10515cecd2821cc8123","X-Request-Id":"b8ac36e3-f72c-4146-b43b-d61b02fb92f0"}}, "res": {"statusCode":404}, "responseTime": 0}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the HTTP logging middleware adds the request ID to its context fields twice and ignores any other context values in the logger.
This change removes the excessive request ID fields and uses a context logger, which automatically has the request ID available. This simplifies the middleware a bit but also allows for other context values to be propagated in the logging context, eg. subject when OAuth2.0 support is added.
The AddContext function is also expanded to merge existing values in the logging context to avoid overriding any values.
This change was extracted from #498 where the subject from JWT tokens will be added as context values. Here it became clear that it wasn't working as intended.