Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't ask for optional but missing args #195

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

kjuulh
Copy link
Contributor

@kjuulh kjuulh commented Nov 22, 2023

This pr makes sure that we don't prompt for optional tokens when interactive. Otherwise people would just need to press enter 4 times in a row for no other benefit

Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
@kjuulh kjuulh requested a review from a team as a code owner November 22, 2023 15:10
@github-actions github-actions bot added the minor label Nov 22, 2023
@kjuulh kjuulh linked an issue Nov 22, 2023 that may be closed by this pull request
@kjuulh kjuulh merged commit eb66e56 into master Nov 23, 2023
2 checks passed
@kjuulh kjuulh deleted the feat/dont-ask-for-optional-args branch November 23, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shuttle interactive api not properly ignoring optional values
2 participants