feat: add support for workspaces and external modules in the same repo #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjuulh
force-pushed
the
feat/with-local-directory
branch
2 times, most recently
from
9920762
to
1ef3449
Compare
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
kjuulh
force-pushed
the
feat/with-local-directory
branch
from
1ef3449
to
c662fce
Compare
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
mahlunar
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a few things:
This is because you may want to use the local packages in the repository in case your actions need to depend on your service or library code.
If workspaces exist, we depend on that solely, as that should tell us where all the subpackages are located
Else if a root module exist we add that. As such both are optional.
It should also work under least surprises, that is if it works in ./actions folder, it should work when the final binaries are compiled
Fixes: AURA-1465, AURA-1466