fix: git chosen requires tag for checkout #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because if we accept values it will not be interpreted, and for git it means falling back on head, which is usually master We'd rather want it to fail instead Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
|
fyi @Crevil if interested =D |
mahlunar
approved these changes
Mar 15, 2024
Signed-off-by: Kasper J. Hermansen <contact@kjuulh.io>
Crevil
reviewed
Mar 16, 2024
|
@Crevil good point. I did "test" it, but forgot to actually write an actual test for it =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because if we accept values it will not be interpreted, and for git it means falling back on head, which is usually master
We'd rather want it to fail instead
Fixes: AURA-1896