Fix stdout and stderr handling in sub commands #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the shell executor and gitCmd helper writes exessive newlines during execution after the upgrade of go-cmd/cmd where handling of the Stderr and Stdout channels was changed. The update was introduced in dd2f8b3 to fix missing output of git-plan commands but was mistakenly not ported to the other uses of the cmd package. This change set updates usage of package cmd when configured with streaming output.
jweibel22
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the shell executor and gitCmd helper writes exessive newlines during
execution after the upgrade of go-cmd/cmd where handling of the Stderr and
Stdout channels was changed.
The update was introduced in dd2f8b3 to fix
missing output of git-plan commands but was mistakenly not ported to the other
uses of the cmd package.
This change set updates usage of package cmd when configured with streaming
output.