Process file list #115
Process file list #115
Conversation
|
"mdcat - -" does not work through the cli parser. It detects one of the dashes as an incomplete argument. It would also fail in pipelines when the first stdin would close and the pipeline is closed. I will make the changes over the weekend when I get some me time. 😄 |
|
Correction. I was running the older mdcat command. The "mdcat - -" does work but it will still make pipelines fail. |
|
I’m sorry, can you please fix CI? |
|
I am going to delete this PR since the errors are coming from code I did not modify and start over. The code I have compiles just fine. |
|
I didn’t check the actual error on CI, perhaps I made a mistake in the CI setup 🤷♂️. If you like I can check 🙂 |
|
I did not touch formatting.rs or lib.rs for the latest fixes. I going to double-check the merge as well. |
|
Figured it out. It was in the tests cases. |
|
I am not seeing a way squash commits after the fact. |
|
Use “git rebase -i” and force-push the result. There are lots of tutorials about this on the internet 🙂 |
|
Learned something new about git. I knew about the rebase command, but I did not know I could do it on a remote forked repository. All the examples were on the master and in PR case, we need to use upstream/master. It got me into conflict detect h-ll but figured it out after a @while. |
2) Redid ownership on TerminalCapabilities 3) Undo debugging code on the arg processing loop 4) Corrected exit return value 5) Make capabilities a reference for the test cases 6) Add change log entry
2) Redid ownership on TerminalCapabilities 3) Undo debugging code on the arg processing loop 4) Corrected exit return value 5) Make capabilities a reference for the test cases 6) Add change log entry
2) Redid ownership on TerminalCapabilities 3) Undo debugging code on the arg processing loop 4) Corrected exit return value 5) Make capabilities a reference for the test cases 6) Add change log entry
2) Redid ownership on TerminalCapabilities 3) Undo debugging code on the arg processing loop 4) Corrected exit return value 5) Make capabilities a reference for the test cases 6) Add change log entry
|
I'm sorry but this:
doesn't look quite right, does it? Why the same message so many times, and what are all these merge commits? Also, why do you prefix the commit message with |
|
GIt was giving me hassles over trying to squash the commit messages. I do
not know why git was forcing me to keep merging.
…On Mon, Jan 6, 2020 at 1:11 PM Sebastian Wiesner ***@***.***> wrote:
I'm sorry but this:
[image: commits]
<https://user-images.githubusercontent.com/224922/71849020-53c5ee00-30d1-11ea-83aa-24f2e55f4887.png>
doesn't look quite right. Why the same message so many times, and what are
all these merge commits? Also, why do you prefix the commit message with
1)?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#115>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADI6CKBLNQTMKPZHJDXFBUTQ4ONB3ANCNFSM4KBX57FQ>
.
--
[image: Logo] <https://www.starkandwayne.com/> [image: Logo]
Norman Abramovitz
Technical Director
T: (650) 799-4478
www.starkandwayne.com
10 John James Audubon Pkwy | Amherst, NY 14228
[image: LinkedIn icon] <https://www.linkedin.com/company/starkandwayne/>
|
--fail-fast if you want to exit on the first failure.
Redid ownership on TerminalCapabilities. Make capabilities a reference for the test cases. Add change log entry Converted code from fail-fast to fail-safe Refactor process_arguments into main Added --fail flag to exit on the first file error refactor process_arguments into main
|
@norman-abramovitz Released 0.15.0 with your change. Thanks again :) |
|
@lunaryorn You're welcome. BTW you might want to run cargo update sometime in the near future. 😄 |
Added code to process multiple files
resolves #54