limel-dialog is shown cramped within the related-view

[CarlitoSweden]

Current behavior

limel-dialog is shown cramped in within the related-view and not in the whole browser window when opened.

Expected behavior

The limel-dialog should appear as it does when it's opened from a lime-object container modal style with backdrop

Environment

• lime-elements version: 2.2.1

• Framework used: StencilJS

• Logs: Nothing more but the unrelated usual focus-trap error

[adrianschmidt]

Hi!

Sorry for not responding earlier, I wasn't set as watching the whole repo, just mentions.

Are you using lime-elements in a plugin that you then use inside the webclient? If so, could you send me the plugin? Otherwise, if you could upload a screenshot or a gif of the behaviour, that would be very helpful 👍

[adrianschmidt]

AFK discussion sum-up:

The problem is that limel-dialog places the dialog element next to the trigger element in the DOM. This means that when shown in the related-view, the dialog can't overflow the confines of the related-view since any overflow is hidden.

This probably isn't anything we can fix in limel-dialog itself. I can see two different ways of fixing it:

• The addonApp functionality that @jtennlo is working on will probably give us the fastest way to resolve this, since (I believe) it ought to be possible to put a dialog element in the addonApp component, and trigger it from a button in a different component.
• Adding a dialog-service to lime-webclient. This should be a much more robust and much cleaner way to achieve "global" dialogs, but it will probably take a bit longer before we have this implemented.

[adrianschmidt]

The Lundalogik/crm-feature#549 is somewhat related to this. It doesn't explicitly discuss modal-type dialogs, but it discusses dialogs and toasts.

[adrianschmidt]

This is being addressed in Lundalogik/crm-feature#586

Closing this issue.