Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload on mock server error #948

Closed
okwme opened this issue Jul 10, 2018 · 24 comments · Fixed by #1077
Closed

reload on mock server error #948

okwme opened this issue Jul 10, 2018 · 24 comments · Fixed by #1077
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@okwme
Copy link
Contributor

okwme commented Jul 10, 2018

UI Version: 0.7.0

Description: Reloading on testnet server works now thanks to #940 but it still doesn't work on the mock server

@okwme okwme added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss labels Jul 10, 2018
@ricburton
Copy link

screen shot 2018-07-18 at 09 33 05
screen shot 2018-07-18 at 09 33 09
screen shot 2018-07-18 at 09 30 45

This was my experience trying to go on a bold voyage. ⚓️

@faboweb
Copy link
Collaborator

faboweb commented Jul 18, 2018

@ricburton do these error relate to reloading on the mocked network?
The encoding already has an issue: #926
The "Couldn't create account" is fixed in the latest version.
We will very probably release a new version on the new testnet this week.

@ricburton
Copy link

ricburton commented Jul 19, 2018 via email

@faboweb
Copy link
Collaborator

faboweb commented Jul 19, 2018

On which Voyager version are you?

@faboweb faboweb removed the discuss label Jul 24, 2018
@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Jul 26, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 26, 2018

I can't test the mock server because Voyager crashes on startup.

@ricburton
Copy link

ricburton commented Jul 26, 2018 via email

@jbibla
Copy link
Collaborator

jbibla commented Jul 26, 2018

@NodeGuy there was once a way - may have been removed. @faboweb will know.

@ricburton that was most likely an issue with the previous testnet - unrelated to the mock server. we'll have a new version of voyager out for the (hopefully more stable 🤞) gaia-7002 very soon.

@faboweb
Copy link
Collaborator

faboweb commented Jul 26, 2018

Using the env flag "COSMOS_MOCKED=true" should start Voyager in mocked mode.

@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Jul 26, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 26, 2018

@okwme What do you mean by "reloading"? Do you mean "Refresh"? Refreshing works for me on the mock server.

@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Jul 26, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 26, 2018

Blocked: the request is unclear

@ricburton
Copy link

ricburton commented Jul 26, 2018 via email

@faboweb
Copy link
Collaborator

faboweb commented Jul 27, 2018

I can confirm that this is an issue:
2018-07-27 10 32 22

@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 27, 2018

What is it that you're doing? Just switching back and forth between the Live Testnet and the Mock Testnet? I can do that without error.

@faboweb
Copy link
Collaborator

faboweb commented Jul 27, 2018 via email

@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 27, 2018

I can't reproduce it:

reload on mock server

@faboweb
Copy link
Collaborator

faboweb commented Jul 27, 2018

Refreshing the view with CMD+R ;)

@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 30, 2018

When I type CMD+R nothing happens. I don't see it in any of the menus.

Are you starting with yarn start?

@faboweb
Copy link
Collaborator

faboweb commented Jul 30, 2018

CMD+R is refreshing chrome. You have to type it while focussing the dev-tools.

@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Jul 31, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 31, 2018

Thank you, now I can recreate the problem.

The bug is caused by the mock setting not being persisted. Why are we not persisting all of the Vuex state in localStorage?

@faboweb
Copy link
Collaborator

faboweb commented Aug 1, 2018

Hmm, If we persistent the mocked config, Voyager would also be mocked mode on the next start. Do we want that?

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 1, 2018

Yes, why wouldn't we? To me that would be consistent with the principle of least surprise.

@faboweb
Copy link
Collaborator

faboweb commented Aug 3, 2018

The sign-in flow sucks in this case, as the user reopens Voyager and then needs to signin and then switch to the live network to then sign in again.

@faboweb
Copy link
Collaborator

faboweb commented Aug 3, 2018

I would expect Voyager "to just work" again when reopening it again.

@faboweb
Copy link
Collaborator

faboweb commented Aug 3, 2018

Idea how to implement:

  • tell the main thread that we are running in mocked mode
  • on booting, the main thread tells the view thread we are running in mocked mode

But: For simplicity I agree that we just store it as well as balances.et Al. We can then later check if this is confusing for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants