Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix conflict with NERDTree #185

Merged
merged 1 commit into from
Oct 8, 2022
Merged

docs(readme): fix conflict with NERDTree #185

merged 1 commit into from
Oct 8, 2022

Conversation

timsu92
Copy link
Contributor

@timsu92 timsu92 commented Aug 28, 2022

Sorry, I've forgot where did I found this, so I can't provide the link to the issue.

@timsu92
Copy link
Contributor Author

timsu92 commented Aug 28, 2022

I guess this is how it caused:
I have nerdtree-git-plugin installed, which shows the [ ] parentheses(bracket?) by default.
Originally, there's an option in that plugin to disable this. However, I have vim-devicons installed as well. As the readme indicates, I can't disable them.
And then, rainbow changes the color, so they aren't concealed.

@luochen1990
Copy link
Owner

luochen1990 commented Oct 7, 2022

Thanks, this LGTM, and it would be better if the Chinese comment translated into English, so that this plugin will cause less problems in systems where unicode is poorly supported.

@timsu92
Copy link
Contributor Author

timsu92 commented Oct 8, 2022

One of the file is README.md while the other one is suffixed with zh, which means Chinese. So I think people who open that file should be prepared to see the characters.

BTW, contents in README.md and README_zh.md are inconsistent.

@luochen1990
Copy link
Owner

Oh, it's in README_zh.md, then it's not a problem.

BTW, contents in README.md and README_zh.md are inconsistent.

Yes, they are not expected to be consistent in each line, but their main part should be consistant. If not, please tell me.

@luochen1990 luochen1990 merged commit 61f719a into luochen1990:master Oct 8, 2022
@timsu92
Copy link
Contributor Author

timsu92 commented Oct 10, 2022

their main part should be consistant. If not, please tell me.

Sorry but if you can read Chinese, it might be better to just see what's happening. I wanted to list all the differences. Sadly, however, there are just too many😢

Nevertheless, I guess current status is still controllable as many of the differences show that English version is better.

Lastly, thanks for creating this! I really appreciate this work! It saves much of my time from making sure in which parenthesis I'm working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants