Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DAG bug #46

Merged
merged 1 commit into from
Sep 16, 2018
Merged

Fixed DAG bug #46

merged 1 commit into from
Sep 16, 2018

Conversation

FlierKing
Copy link
Contributor

No description provided.

@lin-toto lin-toto merged commit 1a320bc into luogu-dev:master Sep 16, 2018
@YanWQ-monad
Copy link
Contributor

不好意思啊,这个地方的确有 bug,是我当初没有写好,感谢指正。
weight_limit=weight_gen() 我的原意是想要把 weight_gen 函数作为参数传进去的,但是多写了一个括号,然后 weight_limit 又手误了(尴尬)。
但是我认为,weight_limit=weight_gen() 应该改为 weight_gen=weight_gen 会更好。因为看了上下文的代码,weight_gen 函数是一个参数,默认会从 weight_limit 的值自动生成,也可以自定义。如果改为 weight_limit 的话,就抹杀了 weight_gen 参数存在的意义。而改成 weight_gen 的话,则 weight_genweight_limit 参数都可以正常使用。

如果不想折腾就当没看到吧,我就担心到时候有人会提一个 weight_gen 参数没有用的 Issue 而已。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants