[pull] master from chromium:master #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Changing Browser Settings to use PrefsMixin instead of PrefsBehavior, in preparation of migrating prefs/ subfolder to TypeScript. PrefsBehavior is no longer used by Browser Settings and will be moved to c/b/r/settings/chromeos/ in a follow up CL. Also adding the BaseMixin in autofill_page.ts since it uses $$() directly from the HTML template and no longer inherits that helper method from the LegacyElementMixin. Bug: 1234307 Change-Id: I3141aaf99417a6eda84aeef617543e17f425fb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194376 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#926952}
https://chromium.googlesource.com/angle/angle.git/+log/4cb34637fa39..1fdedbd45a55 2021-09-30 ianelliott@google.com Except "loader_windows.h" in export_targets.py 2021-09-30 jmadill@chromium.org Merge extension support docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic31d8bd5f79c7e0f48fc7d7c2e891c3505c01375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197961 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926953}
Bug: 1252958 Change-Id: I935858c7e627b417396a1b2a46396e5c64e097ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194785 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#926954}
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/V3Yo20_ZZLc Bug: 1228536, 1170725 Change-Id: If1a412511cb88f098ac18ee0fbcb1c0d35497888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197976 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/main@{#926955}
This CL fixes the issue where the resulting screenshot would show overlapped content on some parts of the page. Clearing the Canvas for each request fixes the problem. Bug: 1254844 Change-Id: I794b458f89e08f9d86b30c6447fea1471f2efd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198135 Commit-Queue: Yashar Dabiran <yashard@chromium.org> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#926956}
…ttings" This reverts commit f9364b0. Reason for revert: causes build failures on fuchsia after https://crrev.com/c/3195954 landed Original change's description: > [fuchsia] Update strings provider to allow access to about:settings > > about:settings is crashing on fuchsia because some localized strings are > not available. This CL provide these strings on Fuchsia the same way > they are provided on Linux > > Test: Browse about:settings with chromium on Fuchsia > Bug: 1241824 > R=wez@chromium.org > > Change-Id: I4fc408c6806028f0b90a5a39a339dfbe7f34f56e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196110 > Auto-Submit: Benjamin Lerman <qsr@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926787} Bug: 1241824 Change-Id: Iccfa450696b6886fe27064c578e528f7dd48a3ad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198479 Reviewed-by: Travis Skare <skare@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Sophey <sophey@chromium.org> Cr-Commit-Position: refs/heads/main@{#926957}
Bug: 1188290 Change-Id: Iacbc368ddd02840914ae51cec4e02a78d8e4ae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182952 Reviewed-by: Per Åhgren <peah@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#926958}
…quest It's possible for BFCache eviction to happen between the time the NavigationRequest was created and when it actually starts or commits, destroying the restored BFCache entry and RenderFrameHost. This CL ensures that the NavigationRequest can know when that happens and handle it accordingly, by using a WeakPtr instead of a raw pointer for the restored RFH (rfh_restored_from_back_forward_cache_). Bug: 1218114 Change-Id: I4b6101237df2bb7adfc908df9af8558952141c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195673 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#926959}
This action button now has the same labels as History itself. Bug: 1249963 Change-Id: I0993551bc7c449aca141208f795168926f27ce25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198348 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/main@{#926960}
It doesn't clear the whole image, it just marks the image as cleared. Bug: none Change-Id: Idc9beaca7f279b32586065cac7f6d3876d34e2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197799 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#926961}
This CL adds the ability to override a holding space item's a11y name. The new APIs are used to give in-progress downloads an a11y name of: * Downloading <filename>, * Download paused <filename>, or * Download dangerous <filename> This is consistent w/ feedback from a11y reviewers. Note that in-progress download progress is still communicated via the browser's a11y announcements. Bug: 1184438 Change-Id: I3a5bb631fd19c8c532a73bb80b1b418d21fba451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198381 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#926962}
This patch does the following: - Renames expanded_state_new_desk_button to a generic expanded_desks_bar_ button that takes in an icon, text and callback as parameters - Renames the inner button, new_button, in expanded_desks_bar_button to inner_button - Adds an icon, text label and bounds to the expanded_desks_bar_button for Desks Templates - Adds metadata for DeskButtonBase, InnerExpandedDesksBarButton and ExpandedDesksBarButton Added TODOs for animation, implementing UpdateButtonState properly, and refactoring button callback to DeskButtonBase. Test: manual Bug: 1249937 Change-Id: Ifa4487db74ec1bb517c25ec3e0391228e82717b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163422 Commit-Queue: Sophie Wen <sophiewen@google.com> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#926963}
Health metric to keep an eye on performance. Bug: 1244672 Change-Id: I7ad02a7de010c09d6722f29004cb947c5c26cb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150542 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/main@{#926964}
Updated styling to better match official specs. Screenshot: http://shortn/_lnqa3NZac0 Bug: 1205539 Change-Id: If5b7d8b5fe86fbfae4f8df71fe730f385022174d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195378 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#926965}
Adding new GN arg: use_python3 to mb_config.pyl, so that we can use that in BUILD.gn to control whether to run benchmarks using python 3. Trying this on linux-perf-calibration first. Linux-perf and linux-perf-fyi are sharing the same mb config and thus we need tp separate them out later. Bug: chromium:1252452 Change-Id: Ife0b643e80ed315bd90ecb6aefb09746a1b85274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189178 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#926966}
- Show the blue highlight around the individual images when they are focused on by ChromeVox - Before the highlights only showed when the preview area was hovered video: https://drive.google.com/file/d/1dBGidrA_rKSMyytVVkhZ6dT_3olfz2wM/view?usp=sharing&resourcekey=0-0HKSkYh5J6fcWK6cxQh7hA Bug: 1210271 Change-Id: I6128d3b924ae83aab3dcde0258f88b2f525d9683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193679 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#926967}
mabian@ left the project, and we're still running experiments on prediction. Bug: 1052145 Change-Id: I76149661a3c9239a2ae24bce3df242219b4adf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195177 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/main@{#926968}
Bug: 1236276 Change-Id: I6fa6901ec1bc0979c054bca682fb04441e8e2e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198476 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Cr-Commit-Position: refs/heads/main@{#926969}
At this moment we don't have lock that prevents ARC from throttling
in case ARC is provisioning. This leads we switch to throttling
after system server is booted, even not when we set arc.boot_completed
property. This adds new lock that keeps ARC untrottled until it is
provisioned.
BUG=b:188941140
TEST=Locally, confirmed per logs logic works as expected
critical CQ test tast.arc.Boot.vm starts passing faster.
unit test added
provisioning time for zork,octopus is improved 4-10 seconds
eve is improved ~0.5sec
TODO: This affects all ARC fleet however low end device and
particular VM may be especially vulnerable that may be reflected in
provisioning time, including enterprise case. We should verify
results locally or per in-lab results once this is landed.
Change-Id: I77e12f1e93d3b5e003049ee27c9164c2add425ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194517
Commit-Queue: Yury Khmel <khmel@chromium.org>
Auto-Submit: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926970}
Allows derefing const SafeRef<>s. Note that this still allows getting non-const ref/ptr to the inner target from a const SafeRef<>. Like other smart pointers, if it is desired for the target to also be const, need to declare a SafeRef<const T>. Bug: 1025999 Change-Id: I2c04935d749fee9179a1afe7bb74851ef004fc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197491 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#926971}
This CL makes the popup model a private implementation detail of OmniboxEditModel, eliminating the accessor and all remaining usage of the previously-popular public popup_model() accessor. Bug: 1208026 Change-Id: Ida73401a1fd5cfa3080f5db4e00a8d16c14c6753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182340 Reviewed-by: Adam Langley <agl@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@google.com> Cr-Commit-Position: refs/heads/main@{#926972}
…default m96" This reverts commit 7dd982c. Reason for revert: Blocked in launch review on security issue - extensions not shown while they could be viewing page. Original change's description: > [dPWA] Enabling elided extensions icon in web app windows by default m96 > > This removes the 'puzzle piece' icon from web app windows and moves it > into a menu option in the 3-dot menu. > > This is planning on launching in m96. > > Bug: 1155421 > Change-Id: I64bcde645d97034063608e0afdc4f2b15de819d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3161399 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/main@{#921820} Bug: 1155421 Change-Id: I7840c787ebbcaf6f20db54743560338b5df58e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198323 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#926973}
https://skia.googlesource.com/skia.git/+log/091694fe16e1..1e6e919a7e53 2021-09-30 ethannicholas@google.com Moved findAndDeclareBuiltinVariables out of IRGenerator 2021-09-30 johnstiles@google.com Add support for function prototypes in Pipeline stage. 2021-09-30 johnstiles@google.com Mark GLSL reserved names as reserved in SkSL grammar. 2021-09-30 kylecarlstrom@google.com Added TextExpressionAnimator 2021-09-30 egdaniel@google.com Add MtlTexture class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I005668be6d66a4c98b7697e43377b15e6912807c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197958 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926974}
Bug: 1251294 Change-Id: Id81def71eac165c5af02ddc51f96ecfa6f80ae55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179772 Reviewed-by: Olivier Li <olivierli@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#926975}
https://dawn.googlesource.com/dawn.git/+log/ffe5114fed70..75911ca2b53c 2021-09-30 bclayton@google.com dawn_node: Fix Windows build 2021-09-30 cwallez@chromium.org Roll third_party/swiftshader/ 314508f78..562df4889 (122 commits) 2021-09-30 enga@chromium.org Disable DrawIndexedIndirect 2021-09-30 shrekshao@google.com Improvement validation errors: Pipeline.cpp 2021-09-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1ca6fbad8f23 to ee23c1734546 (3 revisions) 2021-09-30 bclayton@google.com dawn_node: Fix macOS build 2021-09-30 cwallez@chromium.org Improve validation errors for CreateQuerySet 2021-09-30 bclayton@google.com dawn_node: Add a tool to run the CTS 2021-09-30 bclayton@google.com dawn_node: Move cmd/idlgen under a src directory 2021-09-30 cwallez@chromium.org AdapterVk: Remove redundant VkPhysicalDevice limit check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I65f5ab04c6bc4b068cbde21490266135a4b970e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197962 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926976}
This CL ensures that calls to GetNativeTheme() in CastToolbarButton are only made when the View is present in a Widget hierarchy. This avoids GetNativeTheme() falling through to the global NativeTheme instance and instead gets the correct instance from the hosting Widget. This has the added benefit of ensuring that colors are correctly updated between theme changes. Bug: 1239676 Change-Id: I41cd5d0645971699d8067d7391396bac522bf922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3094937 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#926977}
The ReadImage path is being deprecated. This should give a performance boost by skipping a PNG decode (in ReadImage) and encode (here). Bug: 1223849 Change-Id: I2a0e29698c6382c7fffe9656488d7b23c6a8f042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193877 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by: Mitsuru Oshima (exo only) <oshima@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#926978}
Code related to Reading List feature flags and params is now located in a new class: ReadingListFeatures Bug: 1252228 Change-Id: I257f94f36bea44e5e964063bd664db2719c6d5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176294 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/main@{#926979}
We need to ensure that Google favicon is showing at the first navigation within the bottom sheet rather than using a default icon. Bug: 1250399 Change-Id: I552364ab7fdd60a30b86cf459e250bd212482485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192390 Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org> Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Cr-Commit-Position: refs/heads/main@{#926980}
Bug: 1254725 Change-Id: I8e6217954890af9b7962fa4d87b9f6b11e1ec349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198951 Commit-Queue: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/main@{#926981}
Bug: 1230867 Change-Id: I6120315df502828879e91f214bddc396dd2d7d54 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198377 Auto-Submit: Jeremy Selier <jerem@google.com> Commit-Queue: Jeremy Selier <jerem@google.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#927066}
Currently, our Guava is out of date and stalling the autoroller. Robolectric uses the desktop version of Guava, and although it also uses the Android version of Guava, the classpath seems to use the desktop Guava version first. Change-Id: I3b7441cca71a0efcc037a9fc6075786d147aa675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198830 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#927067}
This reverts commit c3bc219. Reason for revert: causing the following failures on android-cronet-arm-rel-kitkat-tests: cronet_tests_android on Android device Nexus 5 failed. cronet_unittests_android on Android device Nexus 5 failed. net_unittests on Android device Nexus 5 failed. https://ci.chromium.org/ui/p/chromium/builders/ci/android-cronet-arm-rel-kitkat-tests/18151/overview Original change's description: > [Reland] Set TMPDIR for perfetto_unittests. > > perfetto_unittests uses /data/local/tmp if TMPDIR is not available. > c.f. third_party/perfetto/src/base/temp_file.cc GetSysTempDir(). > However creating temporary files under /data/local/tmp causes > "(errno: 13, Permission denied)" failure, and the tests will > crash. So before running the tests, set TMPDIR to be > context.getCacheDir().getPath(). > > The reverted #925618 used Os.setenv and ErrnoException(API level 21) > which are not supported by Kitkat(API level 19). > (c.f. https://developer.android.com/reference/android/system/Os) > Added the code to see API level. > > Change-Id: I616aa97e16e5bc7b119fdfb0e7d267c74b3f6e89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194030 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/main@{#926728} Change-Id: I655a6f447c16c0cf369573672835acc22a0f32c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198091 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Owners-Override: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/main@{#927068}
Roll Chrome Mac PGO profile from chrome-mac-main-1633024553-d05c8934a00e20cb001afc6bd8f51b18532fe97f.profdata to chrome-mac-main-1633046263-05f06afff1cfaf5beb1059e6cd9bf28a401e4e5c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id386eed13fe45a2e4b0cf64d08f7402fc601db03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199352 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927069}
Roll Chrome Linux PGO profile from chrome-linux-main-1633002876-c35ed24bb42ce46526b95ad1943158ef8ef84a1b.profdata to chrome-linux-main-1633046263-f4e1b7c05f4f3ea6793f2682182321bc006a68bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaefaf4f06c1e40b26e79649e98ba3afe76d5b0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198674 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927070}
This CL accounts for the following changes: - Replace Window Error infobar code with equivalent snackbar implementation (https://screenshot.googleplex.com/AGtTDdexSmKwAQb.png) - Replace Module Install Failure infobar code with equivalent snackbar implementation (https://screenshot.googleplex.com/3VQRqQjJo6FcFJg.png) Bug: 1250460 Change-Id: I17faeb48ddfd47dd1bc769c316327e2ba5945d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166650 Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#927071}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4d3954db70e..0e2fb336b2e7 2021-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I63e8c7ec4953268ce86008d9731d3df5dc407978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199117 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927072}
ShouldCheckAppsForUrl() now always returns false in Ash when Lacros web apps are enabled. ShouldCheckAppsForUrl() can now only return true when web apps are user installable. Bug: 1254598 Change-Id: Ia9672ddb7534b80f8413659d6681241f1c389273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193940 Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#927073}
We're using this value inline often enough to warrant a constant, and more will follow. Bug: 1252039 Change-Id: Id7e81084c8d7c3e3182358fa14be0b6eed8f17e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197973 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/main@{#927074}
Change-Id: I09ff68ab3f22897be4052a9aa9b128111b7612f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198832 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927075}
This CL removes the OmniboxPopupModel entirely. The file remains only for OmniboxPopupSelection and its related methods, which are still in common use. Forwarding methods in OmniboxEditModel now contain the implementations previously in OmniboxPopupModel. The one unified model now controls the state related to the popup. Presence of a non-nullptr popup view is now the way to determine whether popup state is relevant within the model. Bug: 1208026 Change-Id: I5c81128e60496eaf9fd9fa1eee72b015e6b90d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194310 Commit-Queue: Orin Jaworski <orinj@google.com> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/main@{#927076}
The supportedEffects are no longer used after the refactor at CL:1739035. Bug: b:172340451 Test: tast run <ip> camera.CCAUISmoke* camera.CCAUIStress* Change-Id: I9390a2e08add63bcb79c230e51f6ca568b4ceeb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195677 Reviewed-by: Shik Chen <shik@chromium.org> Reviewed-by: Wei Lee <wtlee@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#927077}
Although these tests are marked as [ Skip ] in Chromium TestExpectation,
other CIs (e.g. github.com/web-platform-tests/wpt PR checks) still try
to run these tests, sometimes getting unstable results.
This adds HTMLScriptElement.supports('webbundle') check in the setup
step of these tests, so that browsers that do not support
<script type=webbundle> will immediately fail.
Bug: 1245166
Change-Id: Id3e2974f20201dafeb8097402e691d1337c19439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198062
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927078}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c450f91833f6..2675bf77a225 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: Icdc103443f4f596c058e549ff0475dc3c1c74385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198947 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927079}
Doc: https://docs.google.com/document/d/1h2aSTCJJ815ORzEPzkr7CJIWiQYnBYUOn_lQqDInPJ0 apps::mojom::InstallSource is renamed to InstallReason, so that we can add a new InstallSource to define where the app is installed, e.g. from play store, chrome web store, etc. This is the part 2 to rename InstallSource to InstallReason in AppUpdate to align with apps::mojom::InstallReason, and address the related build issue. There will be follow up CLs to change other related function, variable names[TODO]: 1. Modify crosapi to rename InstallSource to InstallReason. 2. Modify other code, e.g. app platform metrics, to rename the related functions, variables from InstallSource to InstallReason. This CL is pure renaming/refactor, no function change. BUG=1250971 Change-Id: I12d173cddc3a46075a235c0de6f6a17c70888075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192730 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927080}
This reverts commit 57c0453. Reason for revert: No longer needed (and everything in src-internal has been reverted) Original change's description: > Add a field for aliases in EntityMetadata > > Bug: 1254024 > Change-Id: Iae66e214d3b8a3af423db3335c302c6e040fb273 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191480 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#925969} Bug: 1254024 Change-Id: I21e68fcf9df45dc0e9f1a2083beb7c2b3f829bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199390 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927081}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633035316-39e892f6dfe3ae504c982596931556189431e2ab.profdata to chrome-win64-main-1633046263-aec5318bad29ff97aac3e64c920a6f0da28233bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I24c542658b9a20a4cbdafdd9bc758e04c9bf7ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198948 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927082}
To understand the usage of this property. CrOS patch see https://crrev.com/c/3193332 Bug: b:201478824 Test: Build Change-Id: I659970ea152df1db382e7df6e99f820abbde6107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193483 Reviewed-by: Hugo Benichi <hugobenichi@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jie Jiang <jiejiang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927083}
This CL adds promo code offers to the manual fallback in the payments tab. The design doc and the UI can be found here (https://docs.google.com/document/d/1UdrHp4FkeERdP2EhhaQFv1rWw0muogdQS-9mXPXrz3c/edit?pli=1) ** The UX team decided to not show the `no_promo_codes_message`. If promo codes are unavailable, no change is made to the Payments tab. ** Mocks(Icon next to promo code should be G logo instead of GPay): https://drive.google.com/file/d/1ynv0qEDVUogQhB4EmtSbgCf8drffNKNg/view?usp=sharing&resourcekey=0-pR899i2WRpBUzNil78t1-A Implementation: https://drive.google.com/file/d/14uaAi6jY4gI_CrdpzoLqaSCSO3unxw7J/view?usp=sharing&resourcekey=0-zP-LRrZSOh6tOo53cWPMxw Change-Id: Id408aca23fa13a69230aa72dc1cf2c2648b28011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056580 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Matthias Körber <koerber@google.com> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Siddharth Shah <siashah@chromium.org> Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com> Cr-Commit-Position: refs/heads/main@{#927084}
based on CQ bot results - https://ci.chromium.org/p/chromium/builders/try/mac11-arm64-rel/45? Include-Ci-Only-Tests: true Bug: 1249176 Change-Id: I470e77122b00a10b75a857d7327efbda2de146b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193529 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#927085}
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/ab36804e42d4..3b49be074d5c 2021-09-30 absl-team@google.com Googletest export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC asully@google.com,preethim@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: asully@google.com,preethim@google.com Change-Id: Ibc897896faf7c1ab1a5e72330d62a4e06b9e9aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198941 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927086}
This is a reland of 23f813c Original CL was reverted by test failure on linux-chromeos-chrome[1]. By console logs, the test doesn't seem to load the primary page successfully before starting prerendering. So, this CL add some codes to ensure the primary page is loaded. [1] https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/17542/test-results Original change's description: > [mparch] Add a test that prerender doesn't close the safety tip > > This CL is part of MPArch tasks and add a browsertest to ensure > prerender navigation doesn't close the safety tip on the primary page. > > Bug: 1218946 > Change-Id: Ia371a24c8efed9950cf34a542bd564735b0db3ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3161744 > Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#922407} Bug: 1218946 Change-Id: I50260f47127bb82296b527a5675bdf115bba3c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184070 Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/main@{#927087}
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I0d60b1a785ec16887e39dd923a761741a15dc115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197511 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927088}
Using wpt-import in Chromium fec3c41. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Ic54105e18c16ab6ba0024f1571626c747fa009f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197640 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927089}
This change adds some missing functionality to ensure the account key test works for all devices. Some devices append the battery information to the account key when generating the filter, and thus we need to do so as well during the check. Testing via unit tests and confirmed locally that we now match as expected for these devices. Change-Id: I22b5f97f505e1c56ce9930cf02f28a535c9e16b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198306 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#927090}
configurations for new builder based off of Chrome release tags on Mac Bug: 1210373 Change-Id: I9886e941cee6b2973483530d8cc9362d96ea7e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197968 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/main@{#927091}
…HTTPS" This reverts commit d5274c7. Reason for revert: introduced flaky test on Mac Original change's description: > Don't attempt to upgrade zero-suggest autocomplete inputs to HTTPS > > This CL fixes an issue with the Defaulting Typed Navigations to HTTPS > feature. Consider the following scenario: > > 1. User types https://example.com > 2. Navigation completes successfully > 3. User clicks the omnibox and hits enter > 4. Omnibox attempts to upgrade this navigation to HTTPS. > > In step 3, OmniboxEditModel::StartZeroSuggestRequest() creates an > AutocompleteInput using its client's > ShouldDefaultTypedNavigationsToHttps() value and "example.com" as the > input text. This causes AutocompleteInput to enable the HTTP fallback > logic if the HTTPS navigation times out, thus potentially downgrading > the connection. > > This CL fixes this by disabling HTTPS upgrades when starting a zero > suggest request. > > Bug: 1251065 > Change-Id: I7ab007f7334b1366806b01231921a248857d9e19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188350 > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926926} Bug: 1251065,1254919 Change-Id: Id5d1be1e58039bdbc7e66ef529a44b5e6eb92dca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197852 Auto-Submit: Fergal Daly <fergal@chromium.org> Owners-Override: Fergal Daly <fergal@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927092}
Pixel_WebGLPreservedAfterTabSwitch Pixel_WebGLReadPixelsTabSwitch are failing both on ChromeOS VMs and Kevin hardware on the FYI waterfall. Bug: 1240440 Change-Id: I6c48eec8557a119e182e866b7327702f442420fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199039 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/main@{#927093}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )