[pull] master from chromium:master #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b5f94829bdf..c8c20b3dd6ba 2021-10-04 kimanh@chromium.org Manually rolling chromium build DEPS 2021-10-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I015a025637085f9bd9915d2a25002020f1c9b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202013 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927611}
This patch marks: external/wpt/css/css-ruby/ruby-justification-001.html as failure. This test is to test inlinification of ruby text using `<rtc>` without `<rt>`. For browsers not supporting `<rtc>` yet, this means we have a block-in-inline in the ruby base. The current NG passes this test accidentally, failing to justify the last line before block-in-inline. The LayoutNGBlockInInline behavior is more correct for browsers that do not support `<rtc>` yet. Bug: 716930, 27659 Change-Id: I39edac3eb6429df0459edd2fdba456766edb3714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201939 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#927612}
In web (PWA) kiosk mode we support a set of kiosk APIs through companion extensions. We therefore need to allow the call to this API in web kiosk as well. Bug: 1252765 Test: flashed and called API Change-Id: I490901a57b843947f462334b0a088c9121250ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198570 Reviewed-by: Anqing Zhao <anqing@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: Ben Franz <bfranz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927613}
Change-Id: Ic26d547bfe86553afb8a9e7e2b6557c1cb825def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201632 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927614}
This CL adds tests related to closing bidirectional streams in WebTransport: - aborting the writable stream, and checking for the RESET_STREAM signal Note: As mentioned in the test file, tests checking for the STOP_SENDING signal after cancelling the readable stream cannot be tested yet. Bug: 1201569 Change-Id: I1aff7d74d959cc967c40ab1f9573068603a73c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201659 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#927615}
The test is routinely taking nearly 30 seconds, and often times out on Windows. Bug: 1249757 Change-Id: I2370b7f4296f53383301571a26cb1ed77ad54e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199926 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Owners-Override: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927616}
This is an optimistic re-enable, based on the new way of handling the keyboard (see crrev/c/3187231). The tests have shown to be stable locally. Bug: b/197623047 Bug: 1246115 Bug: 1245563 Bug: 1216453 Change-Id: Ifbe6fc74801e04490fc8ab82fce94d8d8fc7072f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199776 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/main@{#927617}
Previously every call to PrivacyScreenController's SetEnforced function would notify any observers of the privacy screen state. This would cause a privacy screen notification toast appear on the screen even if the state hadn't changed e.g. user turned on the privacy screen and then later DLP enforced a privacy screen. The logic in SetEnforced now considers the current status of the privacy screen and only notifies observers when the user has initially turned off the privacy screen and DLP needs to enforce a change. Bug: 1244637 Change-Id: I61d7f7e11c009d9a931ce0282157fa438adaf977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173141 Commit-Queue: Alvin Lee <alvinlee@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#927618}
Allows user to set the base path of the temp directory. Mac can only find apps that are under home directory to open a file. We need to have a way to put the web app in any (temp) folder under home directory for Mac get the correct results. Bug: 1232763 Change-Id: Iea85b7e5aaf7a67a7f97c7e8ee5d101fda8992e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166821 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#927619}
Release_Notes: http://go/eche-x20/relnotes/Main/eche_20211004_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/eche_app/app/+/unXQyV8pIgTeejxRMHeyq7YMaXGblw89efMz2KdnhhcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/eche-app-chromium Please CC eche-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: eche-app@grotations.appspotmail.com Change-Id: I9f9ab05101773115a4ccae26f11fb13f8dd81971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201628 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927620}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I464318ee2b4feb94c6500cc9b702c7dcee541e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200709 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927621}
…tml" This reverts commit 90045c1. Reason for revert: The test is disabled only on linux-bfcache-rel by https://chromium-review.googlesource.com/c/chromium/src/+/3197864. Re-enabling the test on the other bots by reverting this TestExpectation change. Original change's description: > Disable browsers/browsing-the-web/back-forward-cache/events.html > > It's new in https://crrev.com/c/2885636 and failing on the bfcache bot. > > Bug: 1255537 > Change-Id: I8b2437b9deeebaaea53b34c767d81860032a2f3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199899 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Auto-Submit: Fergal Daly <fergal@chromium.org> > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927595} Bug: 1255537 Change-Id: I9e80d90a9a02748d13b5fdda1b37245d9df71027 Cq-Include-Trybots: luci.chromium.try:android-bfcache-rel,linux-bfcache-rel No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197868 Auto-Submit: Hiroshige Hayashizaki <hiroshige@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#927622}
This patch removes the Infobar displayed when a user signs in with sync off, and then opens a new tab. Fixed: 1255033 Change-Id: I65374f1ec14096e18d20367801a06bb1926a0113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199751 Auto-Submit: Maria Lavinia Nedelea <lavinian@google.com> Reviewed-by: Jérôme <jlebel@chromium.org> Commit-Queue: Jérôme <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#927623}
This is another CL that removes USE_X11 define and gn arg usage from //ui/views and also removes IsUsingOzonePlatform condition as it's no longer needed as it always resolves to true. Bug: 1096425 Change-Id: I1147fba44622074126711b2286c725551d5a6956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3186232 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#927624}
Bug: 1255472 Change-Id: Ia804caee42961b6bf4e54724185f6ade5e576207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201673 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Owners-Override: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927625}
This CL removes the DeprecateMenagerieAPI feature as it was already enabled by default. Bug: 1231112 Change-Id: Ibdce5f17dc3b4b99062fed3c3c7e9c0d7e97ee25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190571 Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Alice Wang <aliceywang@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927626}
The methods will be used to replace existing Is...Restricted(), but for now leaving both as the code on the calling side will be changed separately. Rather then just checking the restriction level, the methods will handle both WARN and BLOCK, and in case of WARN, show the modal dialog that lets the user choose whether to proceed. For this reason, the methods need to accept a callback function that handles both allowed and not allowed cases. Bug: 1222814 Change-Id: Ib056c163d86c9e40e1ef941c7c03c66ad6aa11ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182303 Commit-Queue: Aida Zolic <aidazolic@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927627}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c8c20b3dd6ba..b703aae9b8eb 2021-10-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7bb11fa53a8610838eb6efef691578ec354b8201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201560 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927628}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d3b3d88..3122970f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic8f64aa3a004d16d607879866e6cbdc34b6474f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201955 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927629}
This has been rolled out. Note that for this feature, *disabled* is the new state. Bug: 1134564 Change-Id: I4f68e40b61c37b24ba19d73777b3110fd743d9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199777 Reviewed-by: Christoph Schwering <schwering@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#927630}
We may skip FindSvgTextChunks() if bidi reordering and ligatures can not happen. We have to call NGSvgTextLayoutAttributesBuilder even if we skip FindSvgTextChunks(). Bug: 1246395 Change-Id: I865234bcdfd1bd4ffee86d84e7661bf805600191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198019 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#927631}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34ad1da7ee6c..5d2e54e684ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I3e4fe309f83bce0d3ce2a2c525eed06a6cf24569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200887 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927632}
No behavior is changed. The first method is shallow and doesn't offer a useful abstraction. Documentation also seems to indicate they were split for testing purposes, which is no longer required. Bug: None Change-Id: Ie07edae5426eb8c57df9d4f3e9dffc6e1cdd17d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199755 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/main@{#927633}
The buffer scale in Wayland is integral and cannot be zero. At the same time, certain use cases such as forcing the device scale factor to values between 0 and 1 result in that the surface gets a zero buffer scale, which violates the Wayland protocol and terminates the connection with the server. This CL adds ceiling fractional scales when passing them to the surface, so the buffer scale is always greater or equal to the DSF. Bug: 1253604, 1241546 Change-Id: I9cd2ace0a6f6de2e2531edf87a02f2aef195e5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190730 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/main@{#927634}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633326658-55d32c1dc4129ef3dac0b08bc444c35f5ef5e95c.profdata to chrome-win32-main-1633337654-05febac5d286d079ebfab11663a8069042365a6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6c3e844d0907eaabf12854c7cf40760731d13619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201563 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927635}
- Define "query" which queries data attached to the given token. - Add add_completion_callback calls to close WebTransport sessions at the end of tests. Bug: None Change-Id: I8b670c1b0b68298a365f5dbcb0671bf17dc5fa3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199158 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#927636}
This CL implements handling of three network signals: - STOP_SENDING signal on outgoing streams - RESET_STREAM signal on incoming streams - ACK signal for the FIN signal for outgoing streams Bug: 1011392, 1242900, 1250680 Change-Id: Ia15336095b8a5427922700fd7dd6f7e75f378dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192878 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/main@{#927637}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633326658-9ae04a632e53039183dad2ea6cec9d9561dca6aa.profdata to chrome-win64-main-1633337654-919aed836eea2811c24418c8c7d6d322f1e7d71b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6362d05afb46664972580d2e5edb194e0aa3ae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201562 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927638}
When WebTransportError is given to abort() and cancel(), read the streamErrorCode property and use the error code for the error code of reset and stop sending signals. This CL brings the error code from blink to the network service. We still need to implement something in net/ to bring the error code to the server. Bug: 1011392 Change-Id: I3aca02fd4cb584ac6ee9a11996a56b1ebf3d34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197070 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#927639}
Changed edit password dialog to have basic support for adding a new password. It was achieved by making the |existingEntry| optional and introducing |PasswordDialogMode|s. This CL does not introduce behavioral changes for existing view and edit use cases. The further functionality for the add mode (e.g wiring to the add button, website validation) will be added in follow up CLs. Implementation: https://screenshot.googleplex.com/6w8vtiNxvobB4yq Design: https://screenshot.googleplex.com/Bt97qWRxM5TqSi8 Bug: 1236053 Change-Id: I27d51771df9d41bf844ecff0670b81b0fe18c9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3137699 Reviewed-by: dpapad <dpapad@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/main@{#927640}
This reverts commit 414b7d7. Reason for revert: Potential breakage, reported in 1255546. Bug: 1230567, 1255546 Original change's description: > Rename unchecked execCommand method to execCommandForTesting. > > This is a follow-on change to crrev.com/c/3048161. That CL splits the > Document::execCommand signature in two. This change renames the string version > to execCommandForTesting, to prevent inadvertent usage (and thus circumventing > the security checks). > > Bug: 1230567 > Change-Id: If74b27b239e192dd588f162b43751725f959c886 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197150 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927287} Bug: 1230567 Change-Id: I1d1b80d9b557d040c9998647eb55066959843281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199778 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#927641}
Change-Id: Id6398f3e31f8890aaf86a9b2420269381d9815bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201671 Reviewed-by: Sandro Maggi <sandromaggi@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/main@{#927642}
Change-Id: I62aaffc91140d87e46dfe1c0540babb9acbf653f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199927 Commit-Queue: Maria Kazinova <kazinova@google.com> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maria Kazinova <kazinova@google.com> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/main@{#927643}
Preparation for [1], in which we execute additional font matching loops with the intent to drop style bold and italic requests so that DirectWrite does not return undesired simulations. As agreed, let's put this behavior behind a build flag until this behavior can be explicitly controlled at the SkFontMgr or SkFontStyle interface level. Chromium never needs simulations in font matching as it decides on its own when to apply synthetic bolding or synthetic skewing / italic. [1] https://skia-review.googlesource.com/c/skia/+/450676 Bug: skia:12455 Change-Id: I91d7d634e725296b1e252e187772e099423ce934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198176 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#927644}
The locked state for content-visibility:hidden is correct at the end of the lifecycle, but it may flip back and forth due to multiple style recalc passes if the content-visibility depends on a container query. Bug: 1202618 Change-Id: Iceeae75bf9b016ef81dc7b2cd2e115f9095b9fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199923 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#927645}
Sub-test-case `audioRepeatAllModeSingleFileDrive` is also flaky. Bug: 1254831 Change-Id: I1a9bcd1e0d94d6dc9b93f81c579f5dc1ab690e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201678 Owners-Override: Balazs Engedy <engedy@chromium.org> Reviewed-by: Illia Klimov <elklm@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927646}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b703aae9b8eb..f9a6331c5a0f 2021-10-04 dsv@chromium.org Try to speed up testOfflineNetworkConditions to address occasional timeouts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1103146 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I53006fc94bdab5f14599d02d536b04cc5769563e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201565 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927647}
Bug: dawn:571 Change-Id: Id5028f22967ff752e60118f65c9fd53f0109fec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197728 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#927648}
We support replacing real elements with an image from the content property. This affects whether a LayoutObject reports having containment applied or not. Add this check to the ComputedStyle based containment application check. Fixes DCHECK failure in BODY/HTML propagation. Bug: 1254076 Change-Id: Ie6bbd0f87ccbb676bbc88739a15a67312ff1b03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199929 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#927649}
https://dawn.googlesource.com/dawn.git/+log/2f1d02b94bc3..bf8c40b4f1c1 2021-10-04 cwallez@chromium.org Vulkan: Implement StoreOp::Discard 2021-10-02 bajones@chromium.org Validate index formats in SetIndexBuffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1254571 Tbr: cwallez@google.com Change-Id: I862e82410ab14c96d7c26ad273b8ebb253c3c8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201566 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927650}
Introduce network.mojom.WebTransport.Close and network.mojom.WebTransportClient.OnClosed. They are corresponding to https://w3c.github.io/webtransport/#session-terminate and https://w3c.github.io/webtransport/#session-terminated. We have WPTs that tests this change in /wpt/webtransport/close.https.any.js. This is skipped as the test server infrastructure is not ready. Also, the underlying implementation in net/ is not ready so the tests fail even in my local environment. Bug: 1011392, 1242902, 1242906 Change-Id: I460f1a18815dbeee3720a637d9f496a24aed36d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197410 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#927651}
This CL adds tests for: - aborting a unidirectional stream with/without error codes and checking for the RESET_STREAM signal - closing and aborting a unidirectional stream, and checking for the RESET_STREAM signal (Note: this test currently fails as https://github.com/whatwg/streams/blob/main/writable-stream-abort-signal-explainer.md has not been implemented for WebTransport yet) Bug: 1201569 Change-Id: I62258f2dd20f794f7a427f409c2cda8ca30c2453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199157 Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#927652}
https://android.googlesource.com/platform/external/perfetto.git/+log/23b1b0ba5f62..7ebf8a2e875f 2021-10-04 skyostil@google.com Merge "tracing: Support tearing down Perfetto for testing" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9a3a9453cbd39cfca61df9e10be8827f940566c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201567 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927653}
https://chromium.googlesource.com/angle/angle.git/+log/d3764f080f6c..1720c6aa065f 2021-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1cdfcb680631 to f43b9df4c8a9 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ie0967a7341a9c04082c551ec66654a607908872b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200739 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927654}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d2e54e684ff..f10c20f9371a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1255587 Tbr: engedy@google.com Change-Id: I06d900f1a102b3cdd294c4a881d240d0be65ad62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201852 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927655}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3122970f..6414e62e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93e3660caad952d8b59a584a5e7eaacba9248f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201960 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927656}
Use static_assert to ensure that `kNoCopyPaths`, `kAshDataPaths` and `kLacrosDataPaths` don't overlap. Test: None Bug: 1178702 Change-Id: Iba83e8ed69f08ba99644b608c0a3ab7240ed29a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193972 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#927657}
Bug: 1226112 Change-Id: I1d8c8d6e88fd6d4277dbd6748123a44df17de772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199753 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927658}
Roll Chrome Mac PGO profile from chrome-mac-main-1633326658-c6e2f91cc6a29f2ee84853d3b52f4917f12f480e.profdata to chrome-mac-main-1633348314-b48333aa3c6038206ce18a8065a07ef5db095721.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifa82655a9337851ff779c33c5348c8a36e0324c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202291 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927659}
This is temporary workaround until the updater backend returns the correct arguments for Chrome per-system install. Bug: 1255144 Change-Id: Ib3bb112899e511a7a62ad260eb82cb9c44074a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201890 Auto-Submit: Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#927660}
Don't evaluate container queries for pseudo element rules when matching rules for the originating element. If it turns out the originating element is the container, we will use an incorrect evaluator. Also, the flag for HasPseudoElementStyle() may not be set and the pseudo elements never generated. Instead assume the query evaluates to true and have false positives for HasPseudoElementStyle(). Bug: 1217976 Change-Id: I6a80137564a45462c61d14e37f4e3e977ab40832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198258 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#927661}
Maven updated from 3.8.1 to 3.8.3 so the original files are no longer available. Bug: None Change-Id: I99d028c440cb3f24b3a29f0100f222b453225605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202111 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#927662}
Python is currently invoked as an x86_64 binary on arm64 Macs, which ends up invoking the simulator as an x86_64 binary as well. This causes test failures because our tests only have an arm64 slice. We can use the "arch -arch arm64" command to force xcodebuild to run as an arm64 binary, and we use "sysctl sysctl.proc_translated" to detect when it is necessary to force arm64. BUG=1250511 Change-Id: If0fc590f501434a77192f9fbefa8476af23f8aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192655 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/main@{#927663}
GetInstalledVersion now returns the current build's version rather than an empty Version. This convinces UpgradeDetector that no update is available. Bug: 1255658 Change-Id: I0f5a3b63104edb287506a314a49cb17cf8aa1d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198885 Reviewed-by: Benjamin Lerman <qsr@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#927664}
Emitting these events each time a thread goes idle creates quite a bit of overhead when very few tracing categories are enabled, and events are generally very spaced apart (e.g. in some memory benchmarks). Instead, only emit an empty packet if the last packet emitted by the thread was non-empty. Bug: 1250114 Bug: 1021571 Change-Id: I92ab7663e55441afb5e64cf4e4eb1456b9812e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200072 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927665}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )