Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10 fixes #44

Closed
wants to merge 3 commits into from
Closed

Xcode 10 fixes #44

wants to merge 3 commits into from

Conversation

johndpope
Copy link

No description provided.

Copy link

@bazscott bazscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @johndpope - good teamwork :)

@@ -385,7 +385,7 @@
INFOPLIST_FILE = OpenSim/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = "com.pop-tap.OpenSim";
PRODUCT_BUNDLE_IDENTIFIER = com.bazscott.mac.OpenSim;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johndpope Probably wouldn't commit this change, I just did this for my local copy :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually edited using github editor. should be good to go c00d7cb

@liangfenxiaodao
Copy link

May I ask when will this pull request get merged?

@RomainQuidet
Copy link

this pull request does not correct the issue on latest Xcode 10.1

@Bunn
Copy link
Collaborator

Bunn commented Nov 12, 2018

@RomainQuidet you can try this one: #45 I'm using on my machine since the day I sent the PR, seems to be working fine.

@RomainQuidet
Copy link

@Bunn #45 will fail too as deviceJson["availability"] as? String is not a string ... but a Bool. I tried the same on my side, it worked. I had to change availability enum to simple
enum Availability { case available case unavailable }
and the Device init method:
init(udid: String, type: String, name: String, state: String, availability: Bool)
and self.availability = availability ? .available : .unavailable

@RomainQuidet
Copy link

I can do the pull request if you want. It's working on my Mac right now.

@johndpope
Copy link
Author

closing this from above comments.
Unless @luosheng - merges - new PR won't see light of day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants