-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 10 fixes #44
Xcode 10 fixes #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @johndpope - good teamwork :)
@@ -385,7 +385,7 @@ | |||
INFOPLIST_FILE = OpenSim/Info.plist; | |||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks"; | |||
MACOSX_DEPLOYMENT_TARGET = 10.10; | |||
PRODUCT_BUNDLE_IDENTIFIER = "com.pop-tap.OpenSim"; | |||
PRODUCT_BUNDLE_IDENTIFIER = com.bazscott.mac.OpenSim; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johndpope Probably wouldn't commit this change, I just did this for my local copy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually edited using github editor. should be good to go c00d7cb
May I ask when will this pull request get merged? |
this pull request does not correct the issue on latest Xcode 10.1 |
@RomainQuidet you can try this one: #45 I'm using on my machine since the day I sent the PR, seems to be working fine. |
@Bunn #45 will fail too as |
I can do the pull request if you want. It's working on my Mac right now. |
closing this from above comments. |
No description provided.