Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to AutoLayout, drop support for old iOS versions #1

Closed
jlnr opened this issue Jul 18, 2016 · 1 comment
Closed

Migrate to AutoLayout, drop support for old iOS versions #1

jlnr opened this issue Jul 18, 2016 · 1 comment
Labels
enhancement

Comments

@jlnr
Copy link
Member

jlnr commented Jul 18, 2016 •
edited

Not really an enhancement per se, but the layout code in MovieViewController is very inefficient.

MovieDict deploys down to iOS 5.1.1 because that's the lowest target version you can use on the App Store (for now) and in Xcode 7.

When Xcode 8 hits the App Store and only supports targeting iOS 8.0+, this app would make a nice testbed for some newer APIs.
This was referenced Jul 18, 2016
Closed
Closed
@jlnr jlnr mentioned this issue Aug 1, 2016
Closed
@jlnr
Copy link
Member Author

jlnr commented Sep 17, 2016 •
edited

Progress:

  • Drop support and checks for everything before iOS 9
  • Move to UISplitViewController for iPad version #2
  • Rewrite MovieViewController
  • Fix IMDb/Wikipedia buttons
  • Fix Pleco buttons
  • Fix SuggestionView on iPhone

jlnr added a commit that referenced this issue Sep 17, 2016
@jlnr
Update to recommended settings, iOS 9+ (#1)
8557f59
jlnr added a commit that referenced this issue Sep 17, 2016
@jlnr
Rewrite using AutoLayout/IB (#1, #2)
db3b8be
jlnr added a commit that referenced this issue Sep 17, 2016
@jlnr
Fix IMDb/Wikipedia buttons (#1)
82b3b7d
jlnr added a commit that referenced this issue Sep 17, 2016
@jlnr
Fix IMDb/Wikipedia buttons (#1)
1f7e46d
jlnr added a commit that referenced this issue Sep 17, 2016
@jlnr
Fix Pleco buttons (#1)
c0a4ead
jlnr added a commit that referenced this issue Sep 18, 2016
@jlnr
Fix Pleco buttons (#1)
b4bec13
@jlnr jlnr closed this as completed in c36feed Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlnr