Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-1013: PostgreSQL driver: Fix incompatible pointer-to-integer types #157

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

fweimer-rh
Copy link
Contributor

These result in out-of-bounds stack writes on 64-bit architectures (caller has 4 bytes, callee writes 8 bytes), and seem to have gone unnoticed on little-endian architectures (although big-endian architectures must be broken).

This change is required to avoid a build failure with GCC 14.

I'll ask Red Hat Product Security if they think this needs to be tracked as a security vulnerability.

Related to:

These result in out-of-bounds stack writes on 64-bit architectures
(caller has 4 bytes, callee writes 8 bytes), and seem to have gone
unnoticed on little-endian architectures (although big-endian
architectures must be broken).

This change is required to avoid a build failure with GCC 14.
@fweimer-rh fweimer-rh changed the title PostgreSQL driver: Fix incompatible pointer-to-integer types CVE-2024-1013: PostgreSQL driver: Fix incompatible pointer-to-integer types Jan 29, 2024
@fweimer-rh
Copy link
Contributor Author

Red Hat Product Security has assigned CVE-2024-1013 to this issue.

@jubalh
Copy link
Contributor

jubalh commented Jan 29, 2024

Red Hat Product Security has assigned CVE-2024-1013 to this issue.

Isn't Drivers/Postgre7.1/info.c just an example driver that shouldnt be used/built in production anyways?

The drivers in here are historical ones or example drivers.
They are not supported anymore. But can be used as a starting
point to write your own.

From https://github.com/lurcher/unixODBC/blob/master/Drivers/README

@lurcher
Copy link
Owner

lurcher commented Jan 29, 2024 via email

@lurcher lurcher merged commit 249bfcc into lurcher:master Jan 29, 2024
@fweimer-rh
Copy link
Contributor Author

Red Hat Product Security has assigned CVE-2024-1013 to this issue.

Isn't Drivers/Postgre7.1/info.c just an example driver that shouldnt be used/built in production anyways?

Ugh, I had no idea. Looks like we keep building these drivers, but they do not end up shipping as far as I can tell.

@jubalh
Copy link
Contributor

jubalh commented Jan 29, 2024

Ugh, I had no idea. Looks like we keep building these drivers, but they do not end up shipping as far as I can tell.

openSUSE uses psqlODBC instead.

@kloczek
Copy link

kloczek commented Jan 31, 2024

Is it possible to release new version because this commit? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants