feat: provide a non-hiding variant of KZG #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
changed the title
huitseeker
force-pushed
the
nonhiding_kzg
branch
from
c47e926
to
c65b4c1
Compare
emmorais
approved these changes
Aug 15, 2023
Drafts a non-hiding variant of the KZG PCS on univariate Dense polynomial representations Details: - Changed access levels and ordering for various modules and functions like `sumcheck`, `cpu_best_multiexp`, and `mod kzg;`. - Upgraded `halo2curves` version and added new dependencies like `pairing`, `anyhow`, `rand`, and `group`. - Leveraged the UniPoly in sumcheck.rs - Created `non_hiding_kzg.rs` file, introducing new structures and functionalities like `UVUniversalKZGParam`, `UVKZGProverKey`, `UVKZGPoly`, and `UVKZGPCS` along with their implementation and tests. - Modified the import of `Engine` in `kzg.rs` from `halo2curves::pairing::Engine` to `pairing::Engine` (reflecting the new version of halo2curves).
huitseeker
force-pushed
the
nonhiding_kzg
branch
from
c65b4c1
to
7f2bc65
Compare
emmorais
approved these changes
Aug 15, 2023
This was referenced Aug 15, 2023
porcuquine
pushed a commit
that referenced
this pull request
Dec 7, 2023
) - Modified `SuperNovaAugmentedCircuitParams` to be passed by reference in `test_recursive_circuit_with` function and associated instances in `test.rs`. - Updated `SuperNovaAugmentedCircuit::new` method to match changes in the `test_recursive_circuit_with` function. - Revamped arguments handling in `synthesize_non_base_case` and `synthesize` functions in `circuit.rs`, changing from owned types to references to reduce unnecessary cloning. - Altered function body to accommodate the changes for referenced values in `circuit.rs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafts a non-hiding variant of the KZG PCS on univariate Dense polynomial representations
Details:
sumcheck,cpu_best_multiexp, andmod kzg;.halo2curvesversion and added new dependencies likepairing,anyhow,rand, andgroup.non_hiding_kzg.rsfile, introducing new structures and functionalities likeUVUniversalKZGParam,UVKZGProverKey,UVKZGPoly, andUVKZGPCSalong with their implementation and tests.Engineinkzg.rsfromhalo2curves::pairing::Enginetopairing::Engine(reflecting the new version of halo2curves).