Refactor pre-processing SNARK #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified the `padded` function in `ppsnark.rs` - test case for the `padded` function
- Updated clippy configuration by removing and adding specific lints for stricter code checks.
- Refactor `R1CSShapeSparkRepr` in `ppsnark.rs` - Restructure the main loop for simultaneous population of `row`, `col`, and `val_X` vectors.
- Introduced a new module `src/spartan/sumcheck/engine.rs`, - Changed the visibility status of the `sumcheck` module, making it visible within the `spartan` module. - Refactored the file structure as `src/spartan/sumcheck.rs` was renamed to `src/spartan/sumcheck/mod.rs` and a new submodule `engine` was added within the `spartan` crate. - Refactored the import structures in `ppsnark` and `sumcheck::engine`, moving several items to `sumcheck::engine`.
3 tasks
adr1anh
approved these changes
Jan 1, 2024
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 2, 2024
* Refine comments * Eliminate redundant computation * 3bc248d26a48aa4fd51cc500bf2384f63f84c769 Revert "Refine comments" This reverts commit 3bc248d26a48aa4fd51cc500bf2384f63f84c769. * Revert "Eliminate redundant computation" This reverts commit b8e4208992079b559d47d1096187a584f25409bb. * Fix comments typos * Eliminate redundant computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit descriptions: they should each be straightforward.
The last commit performs the pre-processing step of #197 and moves all
SumcheckEngine-related items to a sumcheck sub-module.