ci: Refactor GitHub workflows #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
ci-maintenance
branch
from
5e611b0
to
2cfc373
Compare
huitseeker
force-pushed
the
ci-maintenance
branch
from
2cfc373
to
023ef87
Compare
- The pull request introduces predefined GitHub actions for CI env setup from `lurk-lab/ci-workflows` to simplify the existing Rust action workflow, - A new workflow for generating and deploying crate docs has been added, triggering on push to the `dev` branch and on changes in Rust and Cargo files. - Updates have been made to the dependabot configuration to enable 'minor' and 'patch' types for rust dependencies. - Lastly, a new nightly workflow is set up for sanity checks, including jobs to examine unused dependencies and verify rust version.
huitseeker
force-pushed
the
ci-maintenance
branch
from
023ef87
to
8da31c3
Compare
samuelburnham
previously approved these changes
Jan 5, 2024
huitseeker
force-pushed
the
ci-maintenance
branch
from
0246b4f
to
5d392a2
Compare
samuelburnham
previously approved these changes
Jan 8, 2024
.github/workflows/rust.yml
Outdated
| @@ -26,6 +19,10 @@ jobs: | |||
| env: | |||
| RUSTFLAGS: -D warnings | |||
There was a problem hiding this comment.
Nit: this can be removed as part of the ci-env action
samuelburnham
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request introduces predefined GitHub actions for CI env setup from
lurk-lab/ci-workflowsto simplify the existing Rust action workflow,A new workflow for generating and deploying crate docs has been added, triggering on push to the
devbranch and on changes in Rust and Cargo files.Updates have been made to the dependabot configuration to enable 'minor' and 'patch' types for rust dependencies.
Lastly, a new nightly workflow is set up for sanity checks, including jobs to examine unused dependencies and verify rust version.
After feat: add a workflow to check for unused dependencies ci-workflows#6
After fix: check-lurk-compiles ci-workflows#11
After fix: add dependency name to the check-lurk-compiles workflow ci-workflows#12