ci: Fix GPU merge regression check workflow #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
approved these changes
Jan 16, 2024
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 22, 2024
…me curve cycle (lurk-lab#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
gabriel-barrett
pushed a commit
to gabriel-barrett/arecibo
that referenced
this pull request
Feb 9, 2024
* refactor: Refactor `PublicParams` initialization (`new`) to use `setup` method - Updated the function interface for generating `PublicParams` across several files, replacing the `new` method with `setup`. - The method name change impacts the `benches/recursive-snark-supernova.rs`, `src/supernova/test.rs`, and `src/supernova/mod.rs` files. * Refactor traits that allows implementing different engines for the same curve cycle (lurk-lab#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs similar to those uncovered in lurk-lab/lurk-rs#964, mainly that the regression issue comment would fire regardless of the regression checking step.