chore: more Maintenance #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored test functions within the tests module for greater efficiency and readability. - Removed `DlogGroup` trait usage within the `test_pp_digest_with` function. - Simplified `test_pp_digest` function by removing redundant circuit instantiation.
- Upgraded the rust toolchain version from `1.75` to `1.76.0` in `rust-toolchain.toml` file. - Closes lurk-lab#307
- Shifted `pprof` from `dev-dependencies` to `dependencies` for non-wasm32 targets to optimize benchmarking builds. - Introduced "flamegraph" feature to include `pprof` during benchmarking. - Closes lurk-lab#309
- Streamlined calculation of evaluation points in `compute_eval_points_quad` and `compute_eval_points_cubic_with_additive_term` functions within `src/spartan/sumcheck/mod.rs`.
huitseeker
requested review from
adr1anh,
porcuquine,
storojs72 and
mpenciak
adr1anh
approved these changes
Feb 12, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to commit messages.