Make AllocatedR1CSInstance and AllocatedRelaxedR1CSInstance generic in the size of IO
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenciak
changed the title
AllocatedR1CSInstance and AllocatedRelaxedR1CSInstance generic in the size AllocatedR1CSInstance and AllocatedRelaxedR1CSInstance generic in the size of IO
huitseeker
reviewed
Feb 14, 2024
There was a problem hiding this comment.
From a low level PoV, the code is sometimes a bit complex, but can be simplified, see inline comments.
From a high-level PoV, this gives use generic code in gadgets, that can be used in a scheme-specific manner outside that module, which I think fits the bill: awesome!
|
I think I cleaned up some of the nasty stuff I was doing with iterators, it should be a bit better now! |
mpenciak
force-pushed
the
allocated_r1cs_io
branch
from
bcd9725
to
8eb828e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #321.
The solution adds a const generic parameter to the two structs, and a new constant that is used in both the Nova and SuperNova augmented circuits where the instances are known to have IO of length 2.