Improving Shplonk implementation #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
force-pushed
the
issue-303
branch
3 times, most recently
from
d92eaba
to
7b7f469
Compare
adr1anh
reviewed
Feb 16, 2024
huitseeker
reviewed
Feb 16, 2024
src/provider/shplonk.rs
Outdated
| } | ||
|
|
||
| let C_P: E::G1 = pi.comms.iter().map(|comm| comm.to_curve()).rlc(&q); | ||
| // TODO: revisit C_P computing later with progress in https://github.com/huitseeker/arecibo/tree/rayon-parscan | ||
| let q_powers = HyperKZG::<E, NE>::batch_challenge_powers(q, comms.len()); |
There was a problem hiding this comment.
You can make spartan::powers pub (in crate):
Suggested change
| let q_powers = HyperKZG::<E, NE>::batch_challenge_powers(q, comms.len()); | |
| let q_powers = crate::spartan::powers(q, comms.len()); |
huitseeker
reviewed
Feb 17, 2024
src/provider/shplonk.rs
Outdated
Comment on lines
294
to
299
| #[allow(clippy::redundant_closure)] | ||
| let C_P: E::G1 = comms | ||
| .par_iter() | ||
| .zip_eq(q_powers.par_iter()) | ||
| .fold(|| E::G1::identity(), |acc, (comm, q_i)| acc + *comm * q_i) | ||
| .sum::<E::G1>(); |
There was a problem hiding this comment.
Suggested change
| #[allow(clippy::redundant_closure)] | |
| let C_P: E::G1 = comms | |
| .par_iter() | |
| .zip_eq(q_powers.par_iter()) | |
| .fold(|| E::G1::identity(), |acc, (comm, q_i)| acc + *comm * q_i) | |
| .sum::<E::G1>(); | |
| let C_P: E::G1 = comms | |
| .par_iter() | |
| .zip_eq(q_powers.par_iter()) | |
| .fold(E::G1::identity, |acc, (comm, q_i)| acc + *comm * q_i) | |
| .sum::<E::G1>(); |
There was a problem hiding this comment.
Seems to be irrelevant after rebasing to latest dev which includes #330
adr1anh
previously approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM! Feel free to apply the suggestions by @huitseeker (will re-approve if necessary)
adr1anh
approved these changes
Feb 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* avoid explicit compression/decompression * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
This PR introduces 2 improvements:
Next PR should include careful merging Shplonk and HyperKZG implementations leaving hyperkzg.rs source file and removing shplonk.rs (fixing #302). I expect some more improving of prover performance with this merge.
Concrete results of benchmarking at this stage (Shplonk vs current HyperKZG) are following (similar to #301 (comment) - comparable verifier and improved prover):
P.S. @huitseeker, I saw your WIP branch related to parallel rlc. Please, notify me when you land that, so I can simplify
C_Pcomputing by utilising you work