Nova Forward ports (easy) #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
forward_ports
branch
from
3086bcd
to
52fdfbe
Compare
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Feb 17, 2024
- Companion PR of lurk-lab/arecibo#329
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Feb 17, 2024
- Companion PR of lurk-lab/arecibo#329
storojs72
reviewed
Feb 19, 2024
| @@ -1115,36 +1120,36 @@ mod tests { | |||
| test_pp_digest_with::<PallasEngine, _, _, EE<_>, EE<_>>( | |||
| &TrivialCircuit::default(), | |||
| &TrivialCircuit::default(), | |||
| &expect!["582db42439c0dcfc60d24b023ab83d81d97382ac2efa883c6f23147345efeb01"], | |||
| &expect!["e5a6a85b77f3fb958b69722a5a21bf656fd21a6b5a012708a4b086b6be6d2b03"], | |||
There was a problem hiding this comment.
Why do we have changed test vectors?
There was a problem hiding this comment.
The changes to the R1CS coefficient matrix in src/bellpepper/r1cs.rs change the R1CSWithArity (ex-R1CSShape), and therefore the public parameters, and therefore their hash.
|
@storojs72 As the note in the PR description indicates, the failure in CI is expected, normal, and fixed by the companion PR. |
* move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest
* rename and introduce checks about length * introduce a test about public IO
huitseeker
force-pushed
the
forward_ports
branch
from
52fdfbe
to
20ec171
Compare
mpenciak
approved these changes
Feb 20, 2024
adr1anh
approved these changes
Feb 20, 2024
storojs72
approved these changes
Feb 20, 2024
github-merge-queue bot
pushed a commit
to lurk-lab/lurk-rs
that referenced
this pull request
Feb 20, 2024
* chore: Adapt to Arecibo changes - Companion PR of lurk-lab/arecibo#329 * chore: point the repo back to dev
winston-h-zhang
pushed a commit
to lurk-lab/lurk-rs
that referenced
this pull request
Feb 27, 2024
* chore: Adapt to Arecibo changes - Companion PR of lurk-lab/arecibo#329 * chore: point the repo back to dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources:
Overall:
Note
Companion PR at lurk-lab/lurk-rs#1145