chore: Refactor dependencies in Cargo.toml to no longer fork pasta #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated dependencies in Cargo.toml by switching `pasta_curves` from a git repository to a specific version - Amended `grumpkin-msm` dependency git repository link - Removed the `[patch.crates-io]` section for `pasta_curves` due to the above changes.
huitseeker
force-pushed
the
move_out_from_pasta_fork
branch
from
67a045e
to
1947b55
Compare
porcuquine
approved these changes
Feb 20, 2024
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Feb 20, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml. - Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits. This is obsolete since lurk-lab/arecibo#333
github-merge-queue bot
pushed a commit
to lurk-lab/lurk-rs
that referenced
this pull request
Feb 20, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml. - Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits. This is obsolete since lurk-lab/arecibo#333
winston-h-zhang
pushed a commit
to lurk-lab/lurk-rs
that referenced
this pull request
Feb 27, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml. - Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits. This is obsolete since lurk-lab/arecibo#333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After:
pasta_curvesdependency in Cargo.toml grumpkin-msm#14Details:
pasta_curvesfrom a git repository to a specific versiongrumpkin-msmdependency git repository link[patch.crates-io]section forpasta_curvesdue to the above changes.Note
CI complaining on repo provenance 100% expected until above dependencies merge.
Fixes #332