-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize tracing
crate + implement micro-benchmarking
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
approved these changes
Aug 31, 2023
self.multiply_vec(&Z2) | ||
})?; | ||
|
||
// forgive the horror here, but it's for grouping into one span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beginning of the comment ("forgive the horror") is not super informative especially when things aren't that horrific
winston-h-zhang
added a commit
that referenced
this pull request
Sep 5, 2023
* add tracing spans * more instrumenting * more tracing * use spans ig * more spans * more spans * commit_T spans 🤔 * nice spans * remove commit_T * Add trace for ppsnark and snark * fix cargo.toml and fmt --------- Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next-in-line from downstream PR from lurk-lab/lurk-rs#627, implementing an unified tracing ecosystem. Additionally, we add the
tracing_texray
crate, with allows us to easily visualize spans and benchmarks of lurk. Texray can be enabled wherever and tracing offers a lot of flexibility; please see the documentation for more info (tracing-texray).With this, we can get nice mirco-benchmarks like this:
Looking here suggests that we are spending a surprising amount of time computing
[A-C] Z_{1, 2}
... 🤔