feat: keccak/sha3 gadgets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
keccak
branch
3 times, most recently
from
1c0e137
to
c20c66a
Compare
porcuquine
reviewed
Jan 8, 2024
Comment on lines
+82
to
+85
| &a[x + 5usize], | ||
| &a[x + 10usize], | ||
| &a[x + 15usize], | ||
| &a[x + 20usize], |
There was a problem hiding this comment.
These usize type specifiers here and throughout this file seem unnecessary and just make reading/interpreting the algorithm harder.
There was a problem hiding this comment.
I think they're voluntary: the goal is to make it clear the operand is on an index variable, not on something supposed to represent one of the u64 or Uint64 being modeled here.
There was a problem hiding this comment.
It has the opposite effect for me, since without the annotation this should be fine iff x is of the right type. The annotation makes it feel like some extra work is being done to coerce (although I know that's not the exact semantics either).
porcuquine
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tweaked variant of the zatoichi keccak gadget, ported to bellpepper, with added sha3 for good measure.