fix: Guard ADX Feature #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Jan 8, 2024
There was a problem hiding this comment.
This is good.
While we're at it, can we delete the obsolete dont-implement-sort feature?
huitseeker
reviewed
Jan 8, 2024
build.rs
Outdated
Comment on lines
76
to
92
| match (cfg!(feature = "portable"), cfg!(feature = "force-adx")) { | ||
| (true, false) => Some(default_def.to_string()), | ||
| (false, true) if target_arch == "x86_64" => Some("__ADX__".to_string()), | ||
| (false, false) | ||
| if target_arch == "x86_64" | ||
| && std::is_x86_feature_detected!("adx") => | ||
| { | ||
| Some("__ADX__".to_string()) | ||
| (false, false) => { | ||
| #[cfg(target_arch = "x86_64")] | ||
| if target_arch == "x86_64" && std::is_x86_feature_detected!("adx") { | ||
| Some("__ADX__".to_string()) | ||
| } else { | ||
| None | ||
| } | ||
| #[cfg(not(target_arch = "x86_64"))] | ||
| None | ||
| } |
There was a problem hiding this comment.
Nit: perhaps?
fn determine_cc_def(target_arch: &str, default_def: &str) -> Option<String> {
if cfg!(feature = "portable") && cfg!(feature = "force-adx") {
panic!("Cannot compile with both `portable` and `force-adx` features");
}
if cfg!(feature = "portable") {
return Some(default_def.to_string());
}
if cfg!(feature = "force-adx") && target_arch == "x86_64" {
return Some("__ADX__".to_string());
}
#[cfg(target_arch = "x86_64")]
{
if target_arch == "x86_64" && std::is_x86_feature_detected!("adx") {
return Some("__ADX__".to_string());
}
}
None
}
winston-h-zhang
force-pushed
the
guard-adx
branch
from
a37842e
to
d0aad38
Compare
|
Done |
huitseeker
approved these changes
Jan 8, 2024
winston-h-zhang
added a commit
that referenced
this pull request
Jan 11, 2024
Co-authored-by: Hanting Zhang <winston@lurk-lab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.