Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: witness caching skips the 1st witness. #1226

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

huitseeker
Copy link
Member

  • Optimized the prove_recursively function in RecursiveSNARKTrait for performance enhancement
  • Implemented on-demand computation for first circuit's witness in prove_step

- Optimized the `prove_recursively` function in `RecursiveSNARKTrait` for performance enhancement
- Implemented on-demand computation for first circuit's witness in `prove_step`
@huitseeker huitseeker requested a review from a team as a code owner March 20, 2024 15:18
Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the corresponding change in supernova.rs

@huitseeker
Copy link
Member Author

It's missing the corresponding change in supernova.rs

It's intentional, this is for benchmarking.

@huitseeker
Copy link
Member Author

!benchmark --features cuda

Copy link
Contributor

!gpu-benchmark action failed ❌

https://github.com/lurk-lab/lurk-rs/actions/runs/8361561494

@samuelburnham
Copy link
Member

!benchmark --features cuda

Copy link
Contributor

Benchmark for 090931a

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 1493.9±8.03ms 1474.3±9.15ms -1.31%
LEM Fibonacci Prove - rc = 100/fib/num-200 2.8±0.01s 2.8±0.01s 0.00%
LEM Fibonacci Prove - rc = 600/fib/num-100 1933.9±4.27ms 1842.8±18.73ms -4.71%
LEM Fibonacci Prove - rc = 600/fib/num-200 3.1±0.01s 3.0±0.01s -3.23%

Copy link
Contributor

!gpu-benchmark action succeeded! 🚀

https://github.com/lurk-lab/lurk-rs/actions/runs/8361585884

Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@huitseeker huitseeker added this pull request to the merge queue Mar 20, 2024
Merged via the queue into argumentcomputer:main with commit 17454d2 Mar 20, 2024
11 checks passed
@huitseeker huitseeker deleted the skip_first_witness branch March 20, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants