Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refine git source permissions #1007

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

huitseeker
Copy link
Member

  • Update the unknown-git setting to enforce strict rules
  • Add "lurk-lab" as a new allowed organization on Github
  • disable the gitlab and bitbucket organization permissions

rationale: we had incidents of depending on personal forks before.

- Update the `unknown-git` setting to enforce strict rules
- Add "lurk-lab" as a new allowed organization on Github
- disable the gitlab and bitbucket organization permissions
@huitseeker huitseeker requested a review from a team as a code owner January 1, 2024 18:10
Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock

@huitseeker huitseeker added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
@huitseeker huitseeker added this pull request to the merge queue Jan 2, 2024
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
@huitseeker huitseeker added this pull request to the merge queue Jan 2, 2024
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
Merged via the queue into lurk-lab:main with commit f53cff4 Jan 2, 2024
12 checks passed
@huitseeker huitseeker deleted the deny_nonlurk_git_sources branch January 2, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants