Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print comm pointers correctly #1104

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: print comm pointers correctly #1104

merged 1 commit into from
Feb 9, 2024

Conversation

arthurpaulino
Copy link
Member

Closes #1097

@arthurpaulino arthurpaulino requested a review from a team as a code owner February 8, 2024 13:50
huitseeker
huitseeker approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test, too!

@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit bea2d02 Feb 9, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/fix-comm-ptr-printing branch February 9, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@samuelburnham samuelburnham samuelburnham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commitment printing bug
3 participants
@arthurpaulino @huitseeker @samuelburnham