refactor: Refactor namespace allocations using ns! macro
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
previously approved these changes
Feb 14, 2024
adr1anh
previously approved these changes
Feb 15, 2024
Recursion isn't allowed, but otherwise that's a common pattern, and how |
- This codemod was generated by the command ``` rustby '&mut :[cs].namespace(|| :[e])' 'ns!(:[cs], :[e])' ``` where rustby is an alias for `comby -matcher .rs -extensions .rs -in-place -jobs 10 -exclude-dir "target,.github" -stats -timeout 15 $@` - Comprehensive refactoring done across multiple modules, including `coprocessor/mod.rs`, `coroutine/memoset/env.rs`, `circuit/circuit_frame.rs`, `circuit/gadgets/pointer.rs`, and many more. - Switched from `.namespace()` function to the `ns!` macro throughout the code to improve simplicity and readability.
huitseeker
dismissed stale reviews from adr1anh and arthurpaulino
via
459ddd0
huitseeker
force-pushed
the
switch_to_ns
branch
from
7faec24
to
459ddd0
Compare
arthurpaulino
approved these changes
Feb 16, 2024
wwared
approved these changes
Feb 16, 2024
adr1anh
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where rustby is an alias for
comby -matcher .rs -extensions .rs -in-place -jobs 10 -exclude-dir "target,.github" -stats -timeout 15 $@coprocessor/mod.rs,coroutine/memoset/env.rs,circuit/circuit_frame.rs,circuit/gadgets/pointer.rs, and many more..namespace()function to thens!macro throughout the code to improve simplicity and readability.