Frame-like M now is an associated type #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/proof/mod.rs
Outdated
| pub trait Prover<'a, F: CurveCycleEquipped, M: FrameLike<Ptr, FrameIO = Vec<Ptr>>> { | ||
| pub trait Prover<'a, F: CurveCycleEquipped> { | ||
| /// Associated type for a frame-like datatype | ||
| type M: FrameLike<Ptr, FrameIO = Vec<Ptr>>; |
There was a problem hiding this comment.
Can we have a more distinctive name other than "M"?
There was a problem hiding this comment.
Suggestions? I think M came from Multiframe, but it is outdated indeed. I guess Frame can work
There was a problem hiding this comment.
Yeah, Frame or FrameType would work I think
huitseeker
reviewed
Feb 15, 2024
src/proof/mod.rs
Outdated
| pub trait Prover<'a, F: CurveCycleEquipped, M: FrameLike<Ptr, FrameIO = Vec<Ptr>>> { | ||
| pub trait Prover<'a, F: CurveCycleEquipped> { | ||
| /// Associated type for a frame-like datatype | ||
| type M: FrameLike<Ptr, FrameIO = Vec<Ptr>>; |
arthurpaulino
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to simplify the prover trait