refactor: move prove_from_frames into Prover trait #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Apr 11, 2024
| fn lang(&self) -> &Arc<Lang<F, C>>; | ||
|
|
||
| /// Converts input into Self::Frames according to the rules of the Prover | ||
| fn from_frames( |
There was a problem hiding this comment.
I wasn't thrilled about having to add this method, but I didn't have a better way. Suggestions welcome!
There was a problem hiding this comment.
Can you provide the default implementation in the trait itself so we don't need to replicate them on both provers?
There was a problem hiding this comment.
Well, the problem is that Frame is an associated type of the Prover trait, so I can't make it specific to MultiFrame (or any other concrete type). I could make it generic over Frame, but that seems bad to me.
arajasek
force-pushed
the
asr/refactor-prover
branch
from
2054a7f
to
606147c
Compare
|
Force-pushed to fix up linter, sorry about that. |
samuelburnham
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1217.
lang()method to theProvertraitprove_from_frames()method to theProvertrait with the default implementation extracted from bothNovaandSuperNovafrom_frames()method to theProvertrait to assist theprove_from_frames()method